From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH][gdb] Fix dynamic-stack-buffer-overflow in linespec_lexer_lex_string
Date: Wed, 29 May 2019 18:49:00 -0000 [thread overview]
Message-ID: <875zptxfic.fsf@tromey.com> (raw)
In-Reply-To: <20190524152102.GA19370@delia> (Tom de Vries's message of "Fri, 24 May 2019 17:21:04 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> else if (PARSER_STREAM (parser) - start > 4
Tom> && startswith (PARSER_STREAM (parser) - 4, "[abi"))
Tom> - ++(PARSER_STREAM (parser));
Tom> + ;
I think it's better for empty statements to be more verbose, like:
else if (...)
{
/* Nothing. */
}
This is ok with this change.
Tom
prev parent reply other threads:[~2019-05-29 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 15:21 Tom de Vries
2019-05-29 18:49 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zptxfic.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox