From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102046 invoked by alias); 30 Aug 2019 21:06:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101993 invoked by uid 89); 30 Aug 2019 21:06:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Aug 2019 21:06:08 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAF609981A for ; Fri, 30 Aug 2019 21:06:06 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id BA1271001938; Fri, 30 Aug 2019 21:06:06 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message References: <87ftljah3a.fsf@redhat.com> <20190830195102.8965-1-sergiodj@redhat.com> <6f57653e-e1de-3b86-050b-a4f3ca65ad46@redhat.com> Date: Fri, 30 Aug 2019 21:06:00 -0000 In-Reply-To: <6f57653e-e1de-3b86-050b-a4f3ca65ad46@redhat.com> (Pedro Alves's message of "Fri, 30 Aug 2019 20:54:11 +0100") Message-ID: <875zme748x.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00665.txt.bz2 On Friday, August 30 2019, Pedro Alves wrote: > On 8/30/19 8:51 PM, Sergio Durigan Junior wrote: >> Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html >> >> This very simple patch removes the "\nError: " suffix from the warning >> message printed by nat/fork-inferior.c:trace_start_error. This proved >> to just pollute the screen, causing things like: >> >> Starting program: /usr/bin/true >> warning: Could not trace the inferior process. >> Error: >> warning: ptrace: Permission denied >> >> This "Error: " string is not useful at all, and can confuse things, >> therefore let's just remove it and simplify the resulting messages: >> >> Starting program: /usr/bin/true >> warning: Could not trace the inferior process. >> warning: ptrace: Permission denied >> >> 2019-08-29 Sergio Durigan Junior >> >> * nat/fork-inferior.c (trace_start_error): Remove "\nError: " >> suffix from warning message. > > OK. Thanks, pushed: 47a536d940d2f2bccfec51539b857da06ebc429e -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/