From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109028 invoked by alias); 24 Feb 2020 23:20:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109017 invoked by uid 89); 24 Feb 2020 23:20:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*f:sk:d5e2af7, talked, H*i:sk:d5e2af7 X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Feb 2020 23:20:05 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id EEE7657FA for ; Mon, 24 Feb 2020 17:20:02 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6N18jhPADvBMd6N18jdYtw; Mon, 24 Feb 2020 17:20:02 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2n8rHNTH9wzEW85GtRlwaRB/EkaUX8IsOg6U/6Reeww=; b=YKs6i16dj560O1CTYbik0BzPXt CFmFna6sMxKVeKNFznWzQke4faEBV2lD/WBgF8XB6hN4AdZ8EAkrTxxkNRTMZPY0+4Eo5mgVi6uRx uM63tJx+tsudueFz+MpnDmO5p; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:47860 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j6N18-003vxa-OA; Mon, 24 Feb 2020 16:20:02 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/14] Share DWARF partial symtabs between objfiles References: <20200215165444.32653-1-tom@tromey.com> <87y2ss5019.fsf@tromey.com> <8b11c5f6-771f-69b5-c98c-94ced592132f@simark.ca> <87r1ykn0o7.fsf@tromey.com> <87lfosmzy4.fsf@tromey.com> Date: Mon, 24 Feb 2020 23:20:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 24 Feb 2020 14:18:46 -0500") Message-ID: <875zfvmv31.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00936.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> 0 eeeb07c1120 Share DWARF partial symtabs >> 1 597fab7df48 Move signatured_type::type to unshareable object >> 2 9ec85b37d88 Split type_unit_group >> 3 f4d2c85a250 Introduce dwarf2_enter_objfile and use it >> 4 afcc2a6d028 Remove symtab links from dwarf2_psymtab and dwarf2_per_cu_quick_data >> 5 11fad00951b Introduce dwarf2_unshareable and move die_type_hash >> 6 49fe37ffefb Add objfile member to DWARF batons >> 7 842794fd4d9 Add dwarf2_per_cu_data::index >> 8 cbf63c32179 Fix a memory leak and remove an unused member >> 9 fe38cf467e1 Add "objfile" parameter to two partial_symtab methods >> 10 e0e096e6956 Convert IS_TYPE_UNIT_GROUP to method >> 11 ad71f2eb272 Introduce dwarf2_per_objfile::obstack >> 12 4a127c55a71 Simplify setting of reading_partial_symbols Simon> I don't undersatnd why you say that patches #1-#5 won't be salvaged, I think Simon> they will still be necessary. For example, #1 and #2 are still necessary to Simon> take out objfile-specific parts from dwarf2_per_cu_data, aren't they? Yeah, I suppose so. I think the goal should be to eliminate the dwarf2_enter_objfile stuff, so I suppose really only one patch would be wholly gone; and dwarf2_unshareable changed to sort of the "opposite" patch. Simon> objfile -> dwarf2_per_objfile -> dwarf2_shared_between_objfiles Simon> I find the last one a bit long, although it's clear. I'm open to Simon> any suggestions. We talked on irc and thought dwarf2_per_bfd sounded ok, given that this naming is already used for objfile data. >> Also I have another patch here that adds a subclass of partial_symtab >> for DWARF includes. I *think* this solves the need to wrap the >> compunit_symtab pointer in an optional<>, though it remains hard to be >> completely certain. I'll send that sometime soon, I think it could go >> in separately. Simon> I don't really know about that and the current work uses enough of my brain Simon> cycles, so I could take a look, but only once we are done with the current Simon> series (unless you think it impacts the current series). If it could eliminate the optional, it would simplify some of the code. I'll look at that a bit. Tom