From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.125.2]) by sourceware.org (Postfix) with ESMTPS id 79992383F853 for ; Fri, 22 May 2020 21:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79992383F853 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 14A34401DD883 for ; Fri, 22 May 2020 15:27:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cEtEjSXwoEfyqcEtEjByNs; Fri, 22 May 2020 16:07:36 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bMphi3Tm7wOx9VuuBQK93J/qLrNPltO/Jd4vgBkHzrE=; b=gIt9Y6b/QzgU5Ak7MjF4E1U64u g+iCh3D2UuCARDGnCsFoUcmtJR9Zc7/+3Inhw6MXxFcPwsRB693x7d9cg2gPsG1BmfIm+IRuVTbzQ Tne+OdKIxEmnvgvieNVIaiCsX; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36260 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcEtD-004Ehw-QV; Fri, 22 May 2020 15:07:35 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles References: <20200512210913.5593-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 22 May 2020 15:07:34 -0600 In-Reply-To: <20200512210913.5593-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 12 May 2020 17:08:31 -0400") Message-ID: <875zcn1xwp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcEtD-004Ehw-QV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36260 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 21:07:38 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The big difference between v1 and v2 is how the split is done. [...] Thank you so much for doing this. This is a big improvement over the approach I took. I read through the patches. It was difficult to do without glazing over a bit, so I'm not sure I really did a good job. However, I'm comfortable with the direction you've taken here. Simon> Before: Command execution time: 1.213480 (cpu), 1.214268 (wall) Simon> After: Command execution time: 0.001697 (cpu), 0.001694 (wall) Simon> These are the times of one run, but all runs I did are very close. The "after" Simon> time is surpringly low compared to the original numbers, I hope it doesn't mean Simon> I messed up something and we are skipping something important... I doubt it, more like with the new approach, there just isn't much work to be done in this case. Simon> At some point I tested with all these boards and did not see any regression Simon> (they helped very much to find some issues in the process though): Simon> unix cc-with-debug-names cc-with-dwz cc-with-dwz-m cc-with-gdb-index dwarf4-gdb-index fission-dwp fission readnow Stellar. Tom