From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [50.116.127.1]) by sourceware.org (Postfix) with ESMTPS id 7AA2C3857C4A for ; Sat, 15 Aug 2020 19:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7AA2C3857C4A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 84B513CB2 for ; Sat, 15 Aug 2020 14:45:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 727lkmH4pOIGp727lkSHgX; Sat, 15 Aug 2020 14:45:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qSBMSqF7CuZr42xqhMietuDY3MATe7RJ8n5NZngBTdg=; b=N7pjyvIi4thjnZky9UFCrn3WUa g8N8dIr3HaQ3aXdjiXVPOJUBusVlOZ+RBNDD9HbRbf3E4lUWyTQFNM79UZSOW5520pw4x8yXUImC6 ZIG8qel2gh5NGYJdEszCdnw4L; Received: from 75-166-101-103.hlrn.qwest.net ([75.166.101.103]:59804 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1k727l-001XJS-64; Sat, 15 Aug 2020 13:45:53 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/8] gdbsupport: Make function arguments constant in enum-flags.h References: <44267df2ec496c918c09467d28770f366de15ba5.1597319264.git.andrew.burgess@embecosm.com> X-Attribution: Tom Date: Sat, 15 Aug 2020 13:45:51 -0600 In-Reply-To: <44267df2ec496c918c09467d28770f366de15ba5.1597319264.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 13 Aug 2020 13:58:39 +0100") Message-ID: <875z9jhevk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.101.103 X-Source-L: No X-Exim-ID: 1k727l-001XJS-64 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-101-103.hlrn.qwest.net (bapiya) [75.166.101.103]:59804 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Aug 2020 19:45:57 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Make the arguments used for the operators within enum-flags.h constant Andrew> references where possible. There should be no user visible changes Andrew> after this commit. enum_flags is a standard layout value-like class. Normally the compiler will be able to treat objects of this type as if they were the underlying scalar type -- there will be no abstraction penalty, the object will be passed in registers, etc. So, I think it's best not to use references here, unless there's a strong reason for it. Tom