From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3B+KMhhC0V/VIQAAWB0awg (envelope-from ) for ; Wed, 09 Dec 2020 16:31:04 -0500 Received: by simark.ca (Postfix, from userid 112) id C0A2F1F0A9; Wed, 9 Dec 2020 16:31:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6772B1E590 for ; Wed, 9 Dec 2020 16:31:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A31A39730DD; Wed, 9 Dec 2020 21:31:04 +0000 (GMT) Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.125.2]) by sourceware.org (Postfix) with ESMTPS id 7EE0139730DD for ; Wed, 9 Dec 2020 21:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7EE0139730DD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 04F00405F91EA for ; Wed, 9 Dec 2020 15:31:01 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n736kENvrsvw9n737klOb7; Wed, 09 Dec 2020 15:31:01 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yH0WW6rAhruBt60tUZWTJqV0ifBbDK0Bk8ybSCnngfs=; b=QXHIicbNLtPHJyLriQm19MFcih dWa7RtRdGDpq7hFIWfSg72IFXC59bwGNTepfacCrLvhZitieyVmTU9QaVqyrCK4UiK7G/BTNSLw78 aI4KltJhCP6DkBZmtIoeqJWNr; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:59650 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kn736-0039su-Pf; Wed, 09 Dec 2020 14:31:00 -0700 From: Tom Tromey To: Mihails Strasuns via Gdb-patches Subject: Re: [PATCH] gdb: move bfd_open_from_target_memory to gdb_bfd References: <20201208093447.15381-1-mihails.strasuns@intel.com> X-Attribution: Tom Date: Wed, 09 Dec 2020 14:31:00 -0700 In-Reply-To: <20201208093447.15381-1-mihails.strasuns@intel.com> (Mihails Strasuns via Gdb-patches's message of "Tue, 8 Dec 2020 10:34:47 +0100") Message-ID: <875z5ar7jf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kn736-0039su-Pf X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:59650 X-Source-Auth: tom+tromey.com X-Email-Count: 15 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Mihails" == Mihails Strasuns via Gdb-patches writes: Mihails> This function allows to create a BFD handle using an accessible memory Mihails> range in a target memory. It is currently contained in a JIT module but Mihails> this functionality may be of wider usefullness - for example, reading Mihails> ELF binaries contained within a core dump. Mihails> gdb/ChangeLog: Mihails> 2020-12-07 Mihails Strasuns Mihails> * jit.c (mem_bfd*, bfd_open_from_target_memory): Removed. Mihails> * gdb_bfd.h (gdb_bfd_open_from_target_memory): New function. Mihails> * gdb_bfd.c (mem_bfd*, gdb_bfd_open_from_target_memory): New functions. Hi. Thank you for the patch. It looks good to me. I found a couple of minor nits, but the patch is OK with these fixed. Mihails> +/* Create and initialize a BFD handle from a target in-memory range. */ Mihails> + Mihails> +gdb_bfd_ref_ptr Mihails> +gdb_bfd_open_from_target_memory (CORE_ADDR addr, ULONGEST size, Mihails> + const char *target, Mihails> + const char *filename = nullptr); In the style style, the return type isn't separated from the function name in a declaration. Mihails> + gdb_bfd_ref_ptr nbfd (gdb_bfd_open_from_target_memory ( Mihails> + code_entry->symfile_addr, code_entry->symfile_size, gnutarget)); The formatting here looks weird. Normally breaks would occur before "(". Tom