From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4gi0Es9UMmFFFAAAWB0awg (envelope-from ) for ; Fri, 03 Sep 2021 13:01:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 3BFAE1EE22; Fri, 3 Sep 2021 13:01:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 98DC81EDF5 for ; Fri, 3 Sep 2021 13:01:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D50E384843F for ; Fri, 3 Sep 2021 17:01:01 +0000 (GMT) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 51F4E384B13A for ; Fri, 3 Sep 2021 17:00:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51F4E384B13A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2d.google.com with SMTP id n24so7534114ion.10 for ; Fri, 03 Sep 2021 10:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=NAtHfiepuuov6oYIupK47sDBdtAsw60aIuSf2nsf+0o=; b=D/+7bprNGkgrXlppXAFttZxAIthzyTQHyk2soMi1T8kyvQpXXjNv6RdYpLqWEKPnH8 8bJ3b6n7qFaLuM3rEJAuNm+LjbeCiE/1yQ9zIWg5nb9EeX1QofHujCVB14zuTBL4xood 6QWAN+jaN+guyLkoWlXadk4GFk5wrYe+t/6zcD2VrSsZG7WlfsbagpaVdlPFlpt4+aLW 63K2GeRjCiWt62zcdNUf/+Ttj6B3WgjcvtCl1VPmiGkM6WdpZfGqvksV6aD/uBXhZ4aa 7RqEiyN6d8Lloq7aihWdyJTiObAnAqMXl1Wqz11Ay9XfqQ753F8bBRgXyawCUT06V0yL oYbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=NAtHfiepuuov6oYIupK47sDBdtAsw60aIuSf2nsf+0o=; b=TuWC0zex+/x5gkZ2BWav19LQyC3O3xS5IVnpIKet664m96qSMkdlKYWEPghUeRTnfv JRmsLIb0MtzWdIYL52Vd/2cnJi+WPaaJYovp6oGhDTwvfTPoUFWIA9zZWDqhUHKWOzFZ fhl6NPc+M+gRbxEbedEuhwnId1DMUqF8h9xkF8BdNcDoGhjawRgyAeTZ0HccFJ/M2AlJ pjZQDqG5OcOk7kuLTrSkZUAI39LHY/awG93ADuxnZxDKJSxMJ1D2AIStF6ZuL+y1UZc3 M+axqq16biFxER49/uARmdwP+Qn6otisLhdMVFhqINH4xVI/Wnjrf/YkFbxBf3iNO+lR rCXA== X-Gm-Message-State: AOAM531/K1dj3a40NaeOF7LEObraA9jghZg8XWjAJkLJbzCIAyXMf/KY 837/6UoGdaP6ftV20Rmtr/h9SU5wwrEkLLtm X-Google-Smtp-Source: ABdhPJzjNxfXx+XS2yA4P2xHR+spWtsFI0yy3Pupi+EvDD8EQqPlU46z0cNg1kiR+KjQ7ORi0EHdsQ== X-Received: by 2002:a02:378e:: with SMTP id r136mr16528jar.61.1630688449741; Fri, 03 Sep 2021 10:00:49 -0700 (PDT) Received: from murgatroyd (97-122-72-212.hlrn.qwest.net. [97.122.72.212]) by smtp.gmail.com with ESMTPSA id k21sm2995125ioh.38.2021.09.03.10.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 10:00:49 -0700 (PDT) From: Tom Tromey To: Tom Tromey Subject: Re: [PATCH] Use CORE_ADDR as return type from x86_dr_low_get_addr References: <20210903163219.2590419-1-tromey@adacore.com> <87mtotli5k.fsf@tromey.com> X-Attribution: Tom Date: Fri, 03 Sep 2021 11:00:48 -0600 In-Reply-To: <87mtotli5k.fsf@tromey.com> (Tom Tromey's message of "Fri, 03 Sep 2021 10:48:23 -0600") Message-ID: <875yvhlhkv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Tom> It just seemed to me that, most of the time, the value really is a Tom> CORE_ADDR, and that anyway a CORE_ADDR would definitely be large enough. Thinking about this a bit more -- it seems wrong to me to use uintptr_t (a host type) to represent a register value (a target type). So from this perspective, CORE_ADDR is more correct. Now, it's not completely correct in the sense that not every DR register holds an address. But, it's at least harmless in those cases. Tom