From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix ARM simulator build on Windows
Date: Thu, 16 Dec 2021 07:58:24 -0700 [thread overview]
Message-ID: <875yroy4tr.fsf@tromey.com> (raw)
In-Reply-To: <YbK6hNgrG0bSKo71@vapier> (Mike Frysinger's message of "Thu, 9 Dec 2021 21:25:08 -0500")
>> For a Windows-hosted build with arm-elf as the target, the sim build
>> fails like:
Mike> what is your --host ? guessing it's a mingw toolchain.
Yeah: --host=i686-w64-mingw32
Mike> i'm not keen on relying on open being defined to a simple symbol name and thus
Mike> it will continue to compile. if it's defined to something more complicated, i
Mike> imagine it will still fail to compile.
Mike> #define open(args...) _foo_open(1234, ## args)
I'm not sure that's an allowable redefinition, but as long as the fix
works, it's fine by me. Thank you.
Tom
prev parent reply other threads:[~2021-12-16 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 14:02 Tom Tromey via Gdb-patches
2021-12-10 2:25 ` Mike Frysinger via Gdb-patches
2021-12-16 14:58 ` Tom Tromey via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yroy4tr.fsf@tromey.com \
--to=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox