From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WOKkL3LzB2eCvAgAWB0awg (envelope-from ) for ; Thu, 10 Oct 2024 11:32:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iGsRVM2s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BCDD61E357; Thu, 10 Oct 2024 11:32:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 30C781E355 for ; Thu, 10 Oct 2024 11:32:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB76B3857354 for ; Thu, 10 Oct 2024 15:32:00 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6DD8A3857BBB for ; Thu, 10 Oct 2024 15:31:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6DD8A3857BBB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6DD8A3857BBB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728574304; cv=none; b=MbjzvAiGmtrNqu413i7zoGKi/qQvIF8hkhJPExehOAkOi15FBJ1Do4LL5g+234/Ma/CL0kJJhQLpNGEdeDR+o87+E7oVt0zD79ed9tiOGnSXQAU7ipF2D7Ke1roZIPEeTXdFEdrZMGWbZObDVv4l23vI61Ooj7bA0to79ATkUuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728574304; c=relaxed/simple; bh=kV0HibklAnetarPaUw4EkQtdHb3gwv+AODOfmvAW5Co=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CgRAnKfllBPiYB/ZQIJK9nQNcSEL/NStRgX1cJu4eYRmJp9wPyh14rBx+L24/nV65LMCiFktZD5OlMATnRDR29qhEmvlxWgA4MckQVqqZ9tszosqyyJftDX1PfazR0jec4oDKmwt5pKrS0fMPsviV0zHXSwfXR0QhqeRPtLjbfw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728574301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wIG6Ndzu6J6R/odMo+kUjE8DCcDc6IXi2cc4cc7+dso=; b=iGsRVM2slEPvZ5gJvCoJF+zLx1S6SWCu0J6bbbxpCOs7H7VTeteEAh5J+gcaRKE6DSJbiI r/Qqv4VN6Rnl130qh/ajDIohqh3lDETMbKtyax2IHadN302IVqA0pv3S7VLuxWxu1yNRYX Q3oFPtVg2PhWWUeJ7wXcU77/OI4dFNE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-XDr-UU_xMayyfCtK5YQj_Q-1; Thu, 10 Oct 2024 11:31:40 -0400 X-MC-Unique: XDr-UU_xMayyfCtK5YQj_Q-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a996c29edaaso75415766b.0 for ; Thu, 10 Oct 2024 08:31:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728574299; x=1729179099; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wIG6Ndzu6J6R/odMo+kUjE8DCcDc6IXi2cc4cc7+dso=; b=uWgeqjp8qvIVA1jfmJEIf8sJ5A2DRkNe7LNbw6jjPWhUjwOPPpA5poJyLJLJPe76sZ Gl+8e2RvgJtFc55qlcXo3NgiAkr98zT/bvzkqOFxpQ1hrX+75Q8LXZ9Dy1V4DcDFjG4U pwMz2JvF7l6wyGOCflXsimVcvXE1IrTuCVbG07Pr41Uyew9x7nTf2lsxYsB3T0F8wg4e THmX/rYbR0p987OGAMcsRPTpdkOffYeJCX6dcNU7y8o7/KveUysOGvgoHLSik/Dda+U+ zfpGSP6V10OAXc45wQc9vPDSxmAeYZ2fKfezpG2pxrOcLhKbD3X0TImpkbJ01/in27GP CU+w== X-Forwarded-Encrypted: i=1; AJvYcCVVNAzovEYEgOttXipBZWYCtAo4zpuhiScXwNxdVxHValPxd85hYQvpJ1IN/97gn2LBqOaXaJGwNzWexA==@sourceware.org X-Gm-Message-State: AOJu0YzCqbeK4C9/k5yUoFv6bMEXm8BrXWc/YZaQO6h5k33W4xMJvYof 4c89LpBzmSup6dnZK1EWUEAmrHaS8yh7YIAXRNSSIx0UqpQwqvI0CYgHOKmrzuoZCXXA8nqwBQa qiDn9MnPsXxHvsuPd6bYUuXNMw7o7QTXerv0hda/z1hYupYKQKuWmE4/kC10= X-Received: by 2002:a17:907:c7d1:b0:a8a:8d81:97b1 with SMTP id a640c23a62f3a-a998d20769bmr564052866b.27.1728574299412; Thu, 10 Oct 2024 08:31:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfsZR1unG//Vk6Dq1wyl3EipZ/p2lSWkfqTUHmEwIArh5GND3E/iKvb0E4+5Xi6CPR4M0xcQ== X-Received: by 2002:a17:907:c7d1:b0:a8a:8d81:97b1 with SMTP id a640c23a62f3a-a998d20769bmr564050066b.27.1728574299026; Thu, 10 Oct 2024 08:31:39 -0700 (PDT) Received: from localhost ([195.213.152.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a7ec573csm103434866b.6.2024.10.10.08.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 08:31:38 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Luis Machado , Tom Tromey Subject: Re: [PATCH 1/5] gdbserver: make arch and osabi names gdb::unique_xmalloc_ptr In-Reply-To: <74d60567-2f55-4ca7-87db-e655288dc549@simark.ca> References: <642bc25ebd1e94f3378e109256b1c1229fb5f624.1728407374.git.aburgess@redhat.com> <74d60567-2f55-4ca7-87db-e655288dc549@simark.ca> Date: Thu, 10 Oct 2024 16:31:37 +0100 Message-ID: <875xq0as9y.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: >> diff --git a/gdbserver/tdesc.h b/gdbserver/tdesc.h >> index 534b8b000f5..6fc37d038bc 100644 >> --- a/gdbserver/tdesc.h >> +++ b/gdbserver/tdesc.h >> @@ -54,18 +54,16 @@ struct target_desc final : tdesc_element >> mutable const char *xmltarget = NULL; >> >> /* The value of element in the XML, replying GDB. */ >> - const char *arch = NULL; >> + gdb::unique_xmalloc_ptr arch = nullptr; > > Just a nit, you don't need to initialize unique_ptrs to nullptr, they > are default initialized to that. Fixed. Thanks, Andrew