From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2IN0KlxUCWjLEgIAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 16:58:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=b038Pr1l; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A934B1E0C3; Wed, 23 Apr 2025 16:58:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A23FE1E05C for ; Wed, 23 Apr 2025 16:58:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2509E385780C for ; Wed, 23 Apr 2025 20:58:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2509E385780C Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=b038Pr1l Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id F3EC53858D26 for ; Wed, 23 Apr 2025 20:57:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3EC53858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F3EC53858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745441853; cv=none; b=nnyVuVNq1CIIX01akayUgf2kOlEBNrfofq1BhnL1g9cEl65OREz9XNgnwZeYDPCVAneA+Usg2BLYQf3I1ZDhOH92kel37hkKr092CSJz8KuWaXS4lfEUhm7ulxLf2d+wutmCI2uDXGWyV1r/zJAkwIPtXtsBGbZS8oIXD9QAmbE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745441853; c=relaxed/simple; bh=sXvgmYAIcgNaogdUSPbYbuiZ6j6cXFUmYmvV/oPfFm8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=b/8unB04PTLej81xD7wfuvaUlPu/JNYc0Iu20DbTq+oRAQyOa+bj69OSMFGXg+OJ40idLNIDv0uXA7eSMY7whyagUcucvsMQ9nt8kDb18wErH2P1PuBWZpses8ZmXivAuwVcRz1xKBM9AwImtgOm6fNxvZ3vuZGx4+qF3R6owL4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3EC53858D26 Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id 7bBKuEumKXshw7h9wuKbAz; Wed, 23 Apr 2025 20:57:32 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7h9vuu0Rfp8Cw7h9wuuve2; Wed, 23 Apr 2025 20:57:32 +0000 X-Authority-Analysis: v=2.4 cv=V8N70/ni c=1 sm=1 tr=0 ts=6809543c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=vIF5OqwexwdHI4-StjsA:9 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fvYd/e5WzDQiaC9CAykuS002U417HOLHCg4ACN9R4Mo=; b=b038Pr1lAjQ7zNeTFlJC7LAzN3 NIJMcyXK4raliuKwzyxbgnPmEATvfq1PobhrNPH6U5kUiq+tZstgW2SgzO+jft2+DUspwbpd+oYIW dkt+wYrbs9vSjPtw5Z+m5y30h; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:53322 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u7h9v-00000001Dhd-1LXy; Wed, 23 Apr 2025 14:57:31 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 10/28] Have expand_symtabs_matching work for already-expanded CUs In-Reply-To: <87msc6wr1z.fsf@tromey.com> (Tom Tromey's message of "Wed, 23 Apr 2025 14:39:36 -0600") References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-10-ea91704487cb@tromey.com> <2aca0e1b-6042-4839-b266-a8eb0873c21d@simark.ca> <87msc6wr1z.fsf@tromey.com> X-Attribution: Tom Date: Wed, 23 Apr 2025 14:57:29 -0600 Message-ID: <875xiuwq86.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1u7h9v-00000001Dhd-1LXy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (prentzel) [97.118.46.156]:53322 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJlJFusyrViJhIb0+wmQ7VS/nZrtVHyr1kBBjLgxDu3OsTQDOSDl450/5C0Fwy+ZDGqY46Uwt441wD96wd5UgX1hMLt9MqTmRYgrDj8J0OCs1+p2V6mX w5EygNwhuEoTCxMZtCTF9ENUVgR9s4EabsZPoLHi38h3BslvVtUgU2sQAdEe9GfSToInzei+vpOJMJsMkahKb92ZZvohEpzF5HE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>> + if (!this_cu->files_read) >>> + dw2_get_file_names_reader (reader.cu (), reader.top_level_die ()); Simon> In other spots, this is initialized lazily when something calls Simon> dw2_get_file_names. Why would it not work with expand_symtabs_matching? Tom> It's been a long time since I wrote this but my recollection is that if Tom> the CU is already expanded, then this is never done. Tom> I will take another look. FWIW one benefit to doing the call here is that the cutu_reader has already been constructed. So, it is more efficient. I'll remove it and try to reproduce the crash though. Tom