From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eGfDJQtJCWgAAQIAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 16:09:47 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=rXvkdcP9; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 966F01E100; Wed, 23 Apr 2025 16:09:47 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 18E731E05C for ; Wed, 23 Apr 2025 16:09:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C8F4385772A for ; Wed, 23 Apr 2025 20:09:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C8F4385772A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=rXvkdcP9 Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id D12B03858D26 for ; Wed, 23 Apr 2025 20:09:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D12B03858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D12B03858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745438952; cv=none; b=qrbPnDzBfJC9etXhHYJ20RraJ3CZi5430FsTc8LQqTmIP6yzgulaQjtyAL0sueFZh/2wPQl+P0ZRaal7q9mphDRRQqkuwVs0ekux3TWvblNzY/D7foeDVUm3a0pwjQupXaNPgh3/E9JSzdufcLKd5rEve+EArwdRkCwKdwd639c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745438952; c=relaxed/simple; bh=5KrJIKTw8BD1pUlEPn0T8bkkIaAK2sg8vaGXZaJpfas=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MPtKNb3STQNPKRnapFeQqqjcCeqv44rDqLJ29R0qx+tnddmrlOHZXTtKiq6QRnITTauF7bpSKotZUXwvzPaprhv8ZMAKU9gxHo/VjMeMX3cMNoZe0l08VpnNgV+eRNyyhvMrf+R/GI8vjn/HnN3vxdynB9Cx5wclzv/lOiJy/uc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D12B03858D26 Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id 7PP9uRVZyf1UX7gP8uuTUH; Wed, 23 Apr 2025 20:09:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7gP7urrQARxIG7gP7uUIy2; Wed, 23 Apr 2025 20:09:10 +0000 X-Authority-Analysis: v=2.4 cv=N/viFH9B c=1 sm=1 tr=0 ts=680948e6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=1h_Ns2ByMchybmXuiDgA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=H22D7s79k0jzABklv+OPrU4pa51cZhR45TfLFaQmwEM=; b=rXvkdcP9jtILQ+RQvvVpmgHTQU tf5VMFQT7SqR0RlKK6Qwml1BPKFJReChkVbvwYhYPhZb9S/fv/9XENsDvSnGB+eCAq69TGrFv4m7s w3siO7i3ShA/AZd5Oa22x3oxI; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:33258 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u7gP6-00000000YIE-3g41; Wed, 23 Apr 2025 14:09:08 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 27/28] Make dw_expand_symtabs_matching_file_matcher static In-Reply-To: <92ed741b-8931-45fe-a87d-7a1edb6d8887@simark.ca> (Simon Marchi's message of "Wed, 23 Apr 2025 16:00:17 -0400") References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-27-ea91704487cb@tromey.com> <92ed741b-8931-45fe-a87d-7a1edb6d8887@simark.ca> X-Attribution: Tom Date: Wed, 23 Apr 2025 14:09:06 -0600 Message-ID: <875xiu63od.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1u7gP6-00000000YIE-3g41 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:33258 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLPWtVvGw+gjQl4TUDCqXEnggNpRg9dMCFQGzJyOBMWlTucYqXxv8I4XJeJbRx2iURGghFp2W0YsZ0qTOdiakW7fvzGu8WlldfYkFo6fNWALWIEX2VsB iCCWecxxh2teKtpxEgIip56Y3wZAS6FSPZ4cPxW2CpF2gYGXF9e9VK/HPrin2acVyu+cmJ2zZacBKR7MWqN81hyKgJExg9xeVVc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> @@ -1961,9 +1966,11 @@ dw2_expand_symtabs_matching_one >> return true; >> } >> >> -/* See read.h. */ >> +/* If FILE_MATCHER is non-NULL, set all the >> + dwarf2_per_cu_quick_data::MARK of the current DWARF2_PER_OBJFILE >> + that match FILE_MATCHER. */ Simon> The name dwarf2_per_cu_quick_data sounds outdated, the comment could Simon> perhaps be refreshed, while at it. FWIW I updated the comment already when renaming the vectors in that earlier patch. Tom