From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VOoyNH9eemioiBcAWB0awg (envelope-from ) for ; Fri, 18 Jul 2025 10:47:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OkcCM6Fg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C5A481E11C; Fri, 18 Jul 2025 10:47:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 00D441E089 for ; Fri, 18 Jul 2025 10:47:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74B9D3852743 for ; Fri, 18 Jul 2025 14:47:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 74B9D3852743 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OkcCM6Fg Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4B7F6385EC3F for ; Fri, 18 Jul 2025 14:46:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B7F6385EC3F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B7F6385EC3F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752850014; cv=none; b=VqxH+fG5t22WADa+IMAzaAo8z8n9RMDROtFnAwg/sQli2by+X3dj91mPefhpsu+pEe610aAyzl/UXgCP2RZeLN/tHq+2XcZ6GHyVUdHpTGp+46cjQVmR08i1E/bYGSqEjHcpHidiaWP7B3Tcgk/CgeNKC4RLgFhPVvRla0lsO1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752850014; c=relaxed/simple; bh=0X2r4Lb+9o421q1vaB9xHAJPJjL8K3xl5EMrGLIuNto=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nJiKVxqgrONXB9snhnuOOzGN03dHDZUUPzJEOs2ARZ+XrJjYWTtQMLD5hd2g6gC0ORFVymloOyB1DKZOnacjPwFKAPRqeCk8Z5liA9CUhV6mSi/jVwnUMe4JHl6DzoTDmvxNhdKfWZV0njRCUpskBn/IASBxlTUR9bafdxTImd4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B7F6385EC3F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752850012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OA88Efxl61yBe/vn8jRjNIgXZvrBicFiVhpzGMvc1KM=; b=OkcCM6FgAswqUzsgwf+31sWFwj5wONRPJJYRs+iuJLwqhozlMQ0027WC8n7iSfbNNjkLnU KZsC0zqCExxE60xwEMfC8QK8jl0xLnjXhRjijfCTOP9IarC6StKxe+BukQr81Q8ePbUdoX H0xhlw2D9rLqi4ftZ7Btlp+FcLVuVgk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-daTTg3FLOyioEK4vFPa5YQ-1; Fri, 18 Jul 2025 10:46:51 -0400 X-MC-Unique: daTTg3FLOyioEK4vFPa5YQ-1 X-Mimecast-MFC-AGG-ID: daTTg3FLOyioEK4vFPa5YQ_1752850010 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45626e0d3e1so17683805e9.1 for ; Fri, 18 Jul 2025 07:46:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752850010; x=1753454810; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OA88Efxl61yBe/vn8jRjNIgXZvrBicFiVhpzGMvc1KM=; b=JfdRPLvHt8MBjB5n5yjsTFwBWeE5MctGHdgGlCK30BUhTei3jWcY9/c0MMg+73BbkN kZSkepYz/QyHrMvFor6gXypphPsrq2zt0FXeeA94vgh4Q7NGVt6G08wKrn9dWaHr36LR jvZ02GuELAKGBynIAH43TL2MuvRY4fkiXiydkbLnGa/PBVWejkAUZ7yx2/fA7bsG8LfZ gdI+nBfS+aIt2VcKCs2ogivwpBE45dbFqqnNNgaJg17iQYIfbk6rhLa3teAHf7pbozb5 RIjObC5Dw9gR+0JYN0gjhod9T9OvNZKjzBhOrBejvwy13R7ec/fAD8+ze4lfEYydLarz BIgw== X-Forwarded-Encrypted: i=1; AJvYcCVnIRUrp7xco6xviwb9OuzCQwBfSfVD3C9NNjjq/YLHWRt0vCq3hNWPAp760haJjQXulJKJjw+cBFfthA==@sourceware.org X-Gm-Message-State: AOJu0Yy+SsDy3s6GfFBtfI6l9nPhzPF7b6ejdz9YBhhgNLFxLLoB11pm 7Q46/E/PoAtj1iZArfeq7vsKMmVWztDE0rOwpxh50sFya0WhBMOJQxTuyJ+Bidm9afmdbSQZ8/c SoROO0rbWHT2131JuQPxRarc+lYRif8wdQUibR1H92yCEQvasXBhQ/5LP/jwX04w= X-Gm-Gg: ASbGncv6+MlBkpnbKhSW0fEU4BRxBHuHIYcs96QFwnLoBy6uTHYapvIQvPwZ0Eoq1IY +hWV2oEkIPEAwQ8PL3MZwA33Qpg6b+GPi5hqY/gWMXjHBxucw6W9ZwS1bjlz2o1NbZgUSWyZ48F pqhcSZ4dTC3ogmBINlI/EpazfyOzCkKpNhpltSi+jn98f2+re3KqnQhV4YKIJvS7OyoiUUXafHP AnCcYBOFWu0CK39KmqRitOCAm+1EYGDDYPjgG/Eg6XEVKyOMFGr9+5/D0cM0XH7OrZBp9TK0un5 oLzeJq7MHsLD4omwCpyXCz67tB3cfDKLOCFQkP4YVDBRIfySDHMSGMXEGgxU3Bwh X-Received: by 2002:a05:6000:188b:b0:3a4:f644:95f0 with SMTP id ffacd0b85a97d-3b60e53aca7mr8588090f8f.54.1752850009675; Fri, 18 Jul 2025 07:46:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKilK3QtitueaxAw7+2q8OKs1E0MScPPZOsKZ0MzrKAw41F1SxBiOq4p8eG6rwT7+7Frbk7A== X-Received: by 2002:a05:6000:188b:b0:3a4:f644:95f0 with SMTP id ffacd0b85a97d-3b60e53aca7mr8588069f8f.54.1752850009138; Fri, 18 Jul 2025 07:46:49 -0700 (PDT) Received: from localhost (75.226.159.143.dyn.plus.net. [143.159.226.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4562e818525sm80563085e9.16.2025.07.18.07.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jul 2025 07:46:48 -0700 (PDT) From: Andrew Burgess To: Pawel Kupczak , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb, amd64: return after amd64_analyze_frame_setup if current_pc reached In-Reply-To: <20250701104759.52595-3-pawel.kupczak@intel.com> References: <20250701104759.52595-1-pawel.kupczak@intel.com> <20250701104759.52595-3-pawel.kupczak@intel.com> Date: Fri, 18 Jul 2025 15:46:48 +0100 Message-ID: <875xfplfon.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xSPRcxKGVnjh_bP9UGqpE-J1AhIAgCTsucXD7sl7uME_1752850010 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Pawel Kupczak writes: > Make sure the function bails out early if CURRENT_PC is reached, to > avoid the call to amd64_analyze_register_saves. Thanks for splitting this out. I much prefer seeing smaller patches like this! Approved-By: Andrew Burgess Thanks, Andrew > --- > gdb/amd64-tdep.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c > index 863b29a8c27..e4eb076a55a 100755 > --- a/gdb/amd64-tdep.c > +++ b/gdb/amd64-tdep.c > @@ -2645,6 +2645,9 @@ amd64_analyze_prologue (gdbarch *gdbarch, CORE_ADDR pc, CORE_ADDR current_pc, > return current_pc; > > pc = amd64_analyze_frame_setup (gdbarch, pc, current_pc, cache); > + if (current_pc <= pc) > + return current_pc; > + > return amd64_analyze_register_saves (pc, current_pc, cache); > } > > -- > 2.34.1 > > --------------------------------------------------------------------- > Intel Technology Poland sp. z o.o. > ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. > Spolka oswiadcza, ze posiada status duzego przedsiebiorcy w rozumieniu ustawy z dnia 8 marca 2013 r. o przeciwdzialaniu nadmiernym opoznieniom w transakcjach handlowych. > > Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. > This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.