From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id j8MVBOytsWg0Ug8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 09:41:00 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DIomidDY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E5E711E04C; Fri, 29 Aug 2025 09:40:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 53FC71E043 for ; Fri, 29 Aug 2025 09:40:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB15D385840E for ; Fri, 29 Aug 2025 13:40:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB15D385840E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DIomidDY Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id E648F3858C74 for ; Fri, 29 Aug 2025 13:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E648F3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E648F3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474828; cv=none; b=lQUr3O7CZqCJSQXbDsgKDzbFMUMYepvy6vXPNlgRAp0m/rgCGr+W7ZuLcApxVdlKPS1OKrmnjlg5uUoYDZH5GBgmPP+IdPexbAFaGixGBWEoS0qGxCX+QNR0TRAqNjMlassX2YwIB8qnXMajjUVtNHaFQshSOPdqJGduTk8u+eQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474828; c=relaxed/simple; bh=hcNKMAsPylaZMdWQrSWsp8ccQBnfoV/COMfelokH+uw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=pdZV7biLfJFhaqql0BiD2SvUFE9x6XPHUVkx2ANdH28pz6bzfZWQP4Sz66UK83+Ug2Jns418FXtXpDZUrTxopqck8a/4VXTOVJLaymWaMm9Ydqo6QnmWQ7lPsPno+IFSmInyP+WbgUExufuEHi/syY5s9o2X5a/7w6FD2nGu5CY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E648F3858C74 Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id ru3suNhhB0TeUrzL8ufYZ8; Fri, 29 Aug 2025 13:40:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rzL7uHbfGE5uDrzL8umQmr; Fri, 29 Aug 2025 13:40:26 +0000 X-Authority-Analysis: v=2.4 cv=dtDbC0g4 c=1 sm=1 tr=0 ts=68b1adca a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=0txAGqkc2hj5hk0zV38A:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BHnrfBn0m/7hlagbrsGQ9RfGlOBJBcFGsaz39AWHM4w=; b=DIomidDY5zoNC/jRCJbT4L7Qan ZOZfOKbvZ0AMjF/tBasE5fVb9ItafXy9J/4HCaCru8WrBy8pyGRp9IsAUbuStD/gNQTGEykzMttb+ Eq/fSQiAyIHOAvXM1T8170thc; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:34904 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1urzL6-00000000MFZ-3ygs; Fri, 29 Aug 2025 07:40:25 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdbsupport: make filtered_iterator work with pointers In-Reply-To: <20250828151100.84594-2-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 28 Aug 2025 11:10:50 -0400") References: <20250828151100.84594-1-simon.marchi@efficios.com> <20250828151100.84594-2-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 29 Aug 2025 07:40:22 -0600 Message-ID: <875xe6utyx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1urzL6-00000000MFZ-3ygs X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:34904 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDWVYTx2akqdoCRd1spcuMkKqLIup4Y3zOJnlXOg+/07m2qIVcln3bacsuu4hryDYFlGbmejr8FtKtQtyo5axlBvKjS3smpPU6Ee5eXiplj28r+Swp7K i5m6iS32X7ElUKYq3VFl8XGtHS84CB08Cnxda/xRu0c4OoaymltHq0a8Vcs1ChWa8nruBHS0Rz3Kni5kHKdU4OdKNuTFEVCZEBY= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> It's currently not possible to use filtered_iterator with a pointer as Simon> the base iterator type. This patch makes it possible. I have a question about the forwarding constructor. Simon> + using iterator_category = Simon> + typename std::iterator_traits::iterator_category; Simon> + ; Simon> + using difference_type = Simon> + typename std::iterator_traits::difference_type; Simon> + ; Couple of random ";" there. Simon> @@ -44,6 +46,10 @@ class filtered_iterator Simon> : m_it (std::forward (args)...) Simon> { skip_filtered (); } It seems to me that the presence of this constructor means that some existing code could change meaning. It's not really likely but I wonder how we would know. I also wonder what this constructor is even needed for since it seems like a filtered iterator should just wrap an ordinary one anyway. Tom