From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AZL4Hwh5v2hZaTwAWB0awg (envelope-from ) for ; Mon, 08 Sep 2025 20:47:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ipMBQFc3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7A4C91E0BA; Mon, 08 Sep 2025 20:47:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A12B71E047 for ; Mon, 08 Sep 2025 20:47:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 37CF73858C42 for ; Tue, 9 Sep 2025 00:47:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 37CF73858C42 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=ipMBQFc3 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id E4C4F3858D1E for ; Tue, 9 Sep 2025 00:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4C4F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4C4F3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757378771; cv=none; b=VTrF1+t/LLVoFcZqa7RABib1AF4LNibF32AOaoYqCMfo1p1Gj8fdFuLQSRKlCEwTLh5Ogk8OvNSoBumzrrkEXvMedyoFFYZXHP2lRHluIQ0A6kmi5l2ntfF2Waz6uHyeuo0sdx2OWtPlE2xCA+3FJulzL0I1Ox2q7gglHKdrqf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757378771; c=relaxed/simple; bh=x6+rARZj4rDV1Tije1dgHbH2X1CfvWtYngwOwolCO9w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WkEEZfhbDFPurmVYp4YrKtB7DJL/KbOZrpR2l+saP6IP5+tXrcvP86PQcTIWkuiBDzwnthL/smlZqxHY2WM17xM0pqrOEzoF/uMn18ixUp6PqrAYvqigZ6UX7iqiCaJkvnDNna1ec4OP4R58EgpcF5llW3kPMvWJN91FBP8pC3U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4C4F3858D1E Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id ve9fuX7tQv724vmUsu4hNp; Tue, 09 Sep 2025 00:46:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id vmUru7FsTWIZzvmUru3rNq; Tue, 09 Sep 2025 00:46:09 +0000 X-Authority-Analysis: v=2.4 cv=M7JNKzws c=1 sm=1 tr=0 ts=68bf78d2 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=nrg1hkzhlRruF5MZoRMA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IXa0zvl01046/0+i6EVN40Bkxm5RTsF41UPzhFUiZo0=; b=ipMBQFc3MrsIupHFXQmWurFF9m ckRn161jb8wY8H1JreLXowaVl9AxMu74ORnzhtbY9xFBRCRJkYtudJFxuFHy+tLWvKB12CiU4ZflT +0/a1VNKMlr0sqPmUz50ds7br; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:47442 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uvmUq-00000000l56-3P3z; Mon, 08 Sep 2025 18:46:08 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/7] Move compute_include_file_name earlier In-Reply-To: (Simon Marchi's message of "Mon, 8 Sep 2025 12:08:26 -0400") References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-2-dd2beef9d475@tromey.com> X-Attribution: Tom Date: Mon, 08 Sep 2025 18:46:07 -0600 Message-ID: <875xdsihbk.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uvmUq-00000000l56-3P3z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:47442 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM8i/fD0rNkpA3iFq1znw8UqG1LxL1IhHCy62gHwZUa5eckEUpRKfLxGuiG5AbqZeP7X8TSZHSM4OcBiK4ZkreYi6SwanB53FRKVYB1WJCc57Vc5v1DI 7jTE99h4lpRjwGskYZ3z3NATjqfXlE5VF/K17yWRAhdgbTkaGc0CvVOrRw1CIVv5ovZpfTJBuJKrxF4zgUnaxC7DcluwpLQDjIA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> On 9/7/25 3:29 PM, Tom Tromey wrote: >> I noticed that the compute_include_file_name intro comment was >> slightly wrong, and while looking at this, I also noticed that it has >> a single caller. This patch hoists it slightly so that a forward >> declaration isn't needed. Simon> Looks fine to me, but it isn't clear from the above if you intended to Simon> fix something in the comment (I don't see any changes). The change is just the name of the function it helps: -/* Subroutine of dwarf_decode_lines to simplify it. +/* Subroutine of dw2_get_file_names_reader to simplify it. Tom