Re: [PATCH v2 00/13] reimplement readnow_functions

Jan Vraný
2025-12-02T13:40:14Z

Polite ping.

Thanks!
Jan

On Mon, 2025-11-24 at 19:55 +0000, Jan Vrany wrote:
> Hi,
>
> this v2 of a series that refactors readnow_functions without using DWARF
> data structures.
>
> The v1 submission is here:
>
>   https://inbox.sourceware.org/gdb-patches/20251119200105.3172938-1-jan.vrany@labware.com/
>
> Changes since v1:
>
>  * I have updated readnow_function::search() and find_pc_sect_compunit_symtab()
>    as Tom suggested
>
>  * I have added two more commits to this series:
>
>      gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions
>      gdb/testsuite: fix few tests after change in readnow_functions
>
>    (the latter fixing some test failures I accidentally missed)
>
>  * I have re-run regression tests (with and without -readnow).
>
>  Thanks,
>  Jan
>
>  --
>
>
> Jan Vrany (13):
>   gdb: reimplement readnow_functions::search
>   gdb: implement readnow_functions::has_symbols
>   gdb: implement readnow_functions::has_unexpanded_symtabs
>   gdb: implement readnow_functions::find_last_source_symtab
>   gdb: implement readnow_functions::forget_cached_source_info
>   gdb: implement readnow_functions::lookup_global_symbol_language
>   gdb: implement readnow_functions::print_stats
>   gdb: implement readnow_functions::expand_all_symtabs
>   gdb: implement readnow_functions::find_pc_sect_compunit_symtab
>   gdb: implement readnow_functions::map_symbol_filenames
>   gdb: make readnow_functions to inherit from quick_symbol_functions
>   gdb/testsuite: fix few tests after change in readnow_functions
>   gdb: update message in symbol_file_add_with_addrs after changes in
>     readnow_functions
>
>  gdb/dwarf2/read.c                             | 136 ++++++++++++++----
>  gdb/symfile.c                                 |  17 ++-
>  gdb/testsuite/gdb.base/bfd-errors.exp         |   2 +-
>  gdb/testsuite/gdb.base/cached-source-file.exp |   2 +-
>  gdb/testsuite/gdb.base/code_elim.exp          |  10 +-
>  gdb/testsuite/gdb.base/relocate.exp           |  12 +-
>  gdb/testsuite/gdb.base/style.exp              |   2 +-
>  gdb/testsuite/gdb.base/sym-file.exp           |   4 +-
>  gdb/testsuite/gdb.cp/cp-relocate.exp          |   2 +-
>  .../build-id-no-debug-warning.exp             |  12 +-
>  gdb/testsuite/gdb.debuginfod/crc_mismatch.exp |  12 +-
>  .../gdb.dwarf2/dw2-missing-cu-tag.exp         |   2 +-
>  .../gdb.dwarf2/dw2-objfile-overlap.exp        |   2 +-
>  .../gdb.dwarf2/dw2-using-debug-str.exp        |   2 +-
>  gdb/testsuite/gdb.dwarf2/dw2-zero-range.exp   |  10 ++
>  gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp  |   2 +-
>  gdb/testsuite/gdb.multi/remove-inferiors.exp  |   2 +-
>  gdb/testsuite/gdb.server/target-exec-file.exp |   4 +-
>  .../gdb.threads/detach-step-over.exp          |   2 +-
>  gdb/testsuite/lib/gdb.exp                     |   2 +-
>  20 files changed, 170 insertions(+), 69 deletions(-)