Re: [PATCH v2 01/13] gdb: reimplement readnow_functions::search

Tom Tromey
2025-12-02T17:28:06Z

>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:

Jan> This commit reimplements readnow_functions::search without using DWARF
Jan> data structures. This will allow readnow_functions to be used in other
Jan> cases, for example in JIT reader.

Jan> I was bit surprised to realize that original code did not use lookup_name
Jan> to match symbols at all, and this calling listener with more CUs than
Jan> needed. I did try to use it as described in the comment but run into
Jan> issues (test failures) when completing symbols so I decided not to.

Jan> With this change, running all tests with -readnow shown no regressions
Jan> (on my Debian, x86_64 machine).

Thanks, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom