Re: [PATCH v2 12/13] gdb/testsuite: fix few tests after change in readnow_functions

Tom Tromey
2025-12-02T17:27:27Z

>>>>> "Jan" == Jan Vrany <jan.vrany@labware.com> writes:

Jan> When loading a file with -readnow, GDB prints message like:
Jan> Reading symbols from some_program...
Jan> Expanding full symbols from some_program...

Jan> Commit "gdb: implement readnow_functions::expand_all_symtabs" caused
Jan> slight in output when there are any "complaints" - since after this
Jan> change, CUs are instantiated before call to expand_all_symtabs and
Jan> therefore "complaits" are printed before "Expanding full symbols...",
Jan> breaking dw2-zero-range.exp, build-id-no-debug-warning.exp and
Jan> crc_mismatch.exp

If a previous patch causes a regression, then the test updates should be
included in that patch. The reason is that we generally try to make
patch series bisectable -- obviously this can't always be done perfectly
but it's still good when we know in advance that a patch causes a fail.

Tom