From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qcw4DAEVZWnKgz8AWB0awg (envelope-from ) for ; Mon, 12 Jan 2026 10:36:33 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ObXQ4Slk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2DD931E070; Mon, 12 Jan 2026 10:36:33 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C7F581E070 for ; Mon, 12 Jan 2026 10:36:32 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 513AF4BA2E31 for ; Mon, 12 Jan 2026 15:36:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 513AF4BA2E31 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ObXQ4Slk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 11D194BA2E26 for ; Mon, 12 Jan 2026 15:35:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11D194BA2E26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 11D194BA2E26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768232134; cv=none; b=MWr1bZ26rdX+g/sEc/qKJrFvncuStEQ/L4AVB8p7H9hUOsKZaKeS6jnMDbB6T8j0JYSmYHY66MYJTb/uQVj7qZzpHy6t0LeQ4SZtpg6BuSe5F+A7T0QfVSWMn2Dvt95vBW8Zpd7mwllym6aRmDojGS2/r5bTobIQn0ERPmD096E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1768232134; c=relaxed/simple; bh=78TZaW7QKbMUcg5LrJZQbcMCMRWFZlBpsCI9m7b6Z3c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ck8bdSrSi/9BbJs7ikxKiRhEitkMkI532tpGlTvrVKArIjImmJmF+PizwN7vDBKDPcGtzEZaMvpC+xkWjJixKwDbvdcUyd7KE5LHuvWkMGC0UzFpppqvw8WGW38Gpgv4I7jDTrl8DSIZzYaHxAiMGBxlE24lwC2jEr2HJMHj0j4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 11D194BA2E26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768232133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GUaGaY3lvixM6bD3vr5fDaQqqjzC1bocF1TVwM4rFSc=; b=ObXQ4SlkeLjK0WARKE6OlmXtNyhD2FyKHWZOmqRP8oFmkkYtdVuhvhvg0pCOXyU09jJr2W Tqz5pBmyHjpQE5lZVa4O35ITq92Tf6O81o+WWakdMBLQ7YJWyJYjGJ8YhGtwKcRL4LROs3 zLEWkWpkIYUP7EoLpK0H1LE8oDvHZ+Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-3TBbHjWyOp60NFA2QsApXA-1; Mon, 12 Jan 2026 10:35:32 -0500 X-MC-Unique: 3TBbHjWyOp60NFA2QsApXA-1 X-Mimecast-MFC-AGG-ID: 3TBbHjWyOp60NFA2QsApXA_1768232131 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47d4029340aso67353855e9.3 for ; Mon, 12 Jan 2026 07:35:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768232131; x=1768836931; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GUaGaY3lvixM6bD3vr5fDaQqqjzC1bocF1TVwM4rFSc=; b=UcBiJPNtq7pO/BqKTVKRsMA6FZKRZAhR8/z1gxAT/FIzzYDAiiaw59UP0DE9D2+7V6 8zDlMmKBiLhEHPFQSae9scmtHZ3aoxr/p55oCUCRKV0vp4TWEtkZbYNnGjji65eb31jG AT5hHAV6GzJGmTFzARiR4jyO6KJHqjLb3lma+F3QNXTyaxPU42NAjD5QLx+LbLDaUc8k ILjBMhDPUpvFdW6Fn4qTzKGAEHzsW4DiyVWLTJEuzKHwpwn+Ymq25mm0N/TqtqI9cabH 4Db/J+brqAw0L5+3+2gAyjAM/i3iA5WbZHEhtiDDBgLi8JHYSv2EfiffRnI9i2hv86Jt 0XBg== X-Forwarded-Encrypted: i=1; AJvYcCXxb2r2ypNc4M5k/sifE65enL1N7Kxm/VyIk/8yJjvS/vYs47ojFyg2W4051fCXPGWYD+LcTLN8oXU0vA==@sourceware.org X-Gm-Message-State: AOJu0YxNmHN1ZYFPg9ucWq0zNZiQnMmqFdhoVTF3XNzpjb/L/e9cp2TZ p5cAzM0Uc54M/01qEiL9rUP4i/JxmP6yDDwZd+3KusPPdBwGtFS/bZl5m/N6IrgiQ2LP5ydVc/I eRKsqJPYNdGAV3E2jw3BvLP2JIDcH5CoQBZ2noKgTiOT/6pAaVHRffDmM1GQpfdJc4bd8DJM= X-Gm-Gg: AY/fxX4TcYcABB7wK7Nd7Vq+rMPcHQSAo89cGkNS73u6cbEu/z5y3EVBWLblaKDNA9w LobqQn3AQUtHKAodfPzkNdzYZmGLa1UB40rAnT75Fk9hEx6qEgl/pMLLtDcUvRKwR/x41y2ekW6 mhA7rTUrg7jsrv4M1thXZG18sGVXzbXUaPzIAcrUueWu7S1aqvIy+LTbKWvNmspkoyCYfirzD5R +8mw56PeNsQL7LlP1D8XCnCGVXfzm95H+uLE2FIPGdNiAmPpk4HuPrDfC7SjmwkGHpNKeq1dMnK cY8Ca9FwcUGDMfTgoIdFkohtOY3o0qF93S/5FfdVNe4MNhdAkFZOwFhywL/Bt4fhnicmCj7sE3b AtRa153NWdzWjRlfZOR3TN7JkiYtd X-Received: by 2002:a05:600c:3556:b0:477:8985:4036 with SMTP id 5b1f17b1804b1-47d84b086ccmr222459605e9.1.1768232131087; Mon, 12 Jan 2026 07:35:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCrFD3kv8+SGTwGJV2Ut/O8zITkH2vRfpPkWxKZpLgX8Cgwf/6LP14mLQ0B2aSBjspgWAk5g== X-Received: by 2002:a05:600c:3556:b0:477:8985:4036 with SMTP id 5b1f17b1804b1-47d84b086ccmr222459195e9.1.1768232130670; Mon, 12 Jan 2026 07:35:30 -0800 (PST) Received: from localhost (13.81.93.209.dyn.plus.net. [209.93.81.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e199bsm38874105f8f.16.2026.01.12.07.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 07:35:30 -0800 (PST) From: Andrew Burgess To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: Re: [PATCH v2 1/2] gdb: improve help text for set commands with limited options In-Reply-To: <20260109115621.26003-2-guinevere@redhat.com> References: <20260109115621.26003-1-guinevere@redhat.com> <20260109115621.26003-2-guinevere@redhat.com> Date: Mon, 12 Jan 2026 15:35:29 +0000 Message-ID: <875x96vo72.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oLsV19f2BIb1TuBKRxCmhU-HGbIvl6ae7vyC4WdTJGM_1768232131 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Guinevere Larsen writes: > Some "set" commands only allow a select few options, such as the "set > architecture" command, however, there is no way for a user to know which > options are allowed without trying to set something and getting an > error. This commit improves the situation by making the help command list > all the available options. > --- > gdb/cli/cli-decode.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c > index 04935575b67..06313ba6c49 100644 > --- a/gdb/cli/cli-decode.c > +++ b/gdb/cli/cli-decode.c > @@ -1884,6 +1884,16 @@ help_cmd (const char *command, struct ui_file *stream) > /* Be sure to expand TABs in the documentation. */ > tab_expansion_file expander (stream); > gdb_puts (c->doc, &expander); > + if (c->enums != nullptr) > + { > + gdb_puts ("Available options are:\n", &expander); > + const char * const *opt = c->enums; > + while (opt != nullptr) > + { > + gdb_printf (&expander, "%s\n", *opt); Have you tried this on a build of GDB with all-targets enabled? I suspect this is going to result in rather a long list. It might be better if the options were printed as a comma separated list maybe? Thanks, Andrew > + opt ++; > + } > + } > } > else > { > -- > 2.52.0