From: Tom Tromey <tom@tromey.com>
To: Matthieu Longo <matthieu.longo@arm.com>
Cc: <gdb-patches@sourceware.org>, Tom Tromey <tom@tromey.com>,
Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v1] py-gdb-readline: replace deprecated interfaces in GdbRemoveReadlineFinder
Date: Tue, 13 Jan 2026 09:25:58 -0700 [thread overview]
Message-ID: <875x95jx7t.fsf@tromey.com> (raw)
In-Reply-To: <20260107161854.1712307-1-matthieu.longo@arm.com> (Matthieu Longo's message of "Wed, 7 Jan 2026 16:18:54 +0000")
>>>>> "Matthieu" == Matthieu Longo <matthieu.longo@arm.com> writes:
Matthieu> A previous patch [1] enabled readline in Python in a GDB-specific way
Matthieu> and blocked the standard Python readline module to prevent conflicts
Matthieu> with GDB by adding a custom importer raising an exception for the readline
Matthieu> module.
I wonder if gdb could do better here. To be clear, not your problem.
Matthieu> This patch uses Patryk Sondej's approach detailed in bug 32473, but with
Matthieu> a slight variation regarding the finder insertion in sys.meta_path.
Matthieu> It also adds a new test to prevent future regression.
Seems reasonable to me, though this isn't an area I know very well.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-01-13 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 16:18 Matthieu Longo
2026-01-13 11:34 ` Matthieu Longo
2026-01-13 16:25 ` Tom Tromey [this message]
2026-08-05 13:17 ` Tom de Vries
2026-08-05 15:00 ` Tom de Vries
2026-01-13 16:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x95jx7t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=matthieu.longo@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox