From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zZHmOp13cmnrNBAAWB0awg (envelope-from ) for ; Thu, 22 Jan 2026 14:16:45 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O4i84kE4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D2BAE1E0AD; Thu, 22 Jan 2026 14:16:45 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E3AF11E089 for ; Thu, 22 Jan 2026 14:16:44 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B4BA04BA2E2D for ; Thu, 22 Jan 2026 19:16:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B4BA04BA2E2D Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=O4i84kE4 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id CC9CA4BA9036 for ; Thu, 22 Jan 2026 19:13:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC9CA4BA9036 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC9CA4BA9036 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769109208; cv=none; b=kN5zvaQO5w3Qxqxz4kLnN2dAn6D/wfArHx69SBJDbmDh1Bd6agLrY9eEEqJhnJP9aSj/ASlYoPMdQnJoUBApx6K2nMGg+ABqME39EvVHG9pMVIOQ4k5+RgQ7aHp33I9/Y0OuW2hnocfOfxWnr+nDj3gQAIlr984ftqeZ/FwfeEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769109208; c=relaxed/simple; bh=wCB8FJId0p/sfvbsaKk8MMENHGDWWJyokNrtCRgFyI4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PeO3ZCM2isIRkIzRQFV9LUszTT1r1iP3yVpWmhRAcQrGLnUodhci3BT/ssehkyqBXc9LNNonWN9nZV1G5s5aMs2LVGLOINuv+z+NUqBEloSoFHI0VaE64T/ptey6ccYifWEq8M4i7X1205hLV1zcwCjHd150IbaaWgMhAFmkPu8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC9CA4BA9036 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id ixcivPZ3HKXDJj07TvoA4i; Thu, 22 Jan 2026 19:13:27 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id j07SvxXGRV6WMj07SvKsSJ; Thu, 22 Jan 2026 19:13:26 +0000 X-Authority-Analysis: v=2.4 cv=E//Npbdl c=1 sm=1 tr=0 ts=697276d6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=kD1IslMHPTloZniUikYA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v1z6vMSn2Oj5aCboUe+qRrL2jHzucz9/6FCvJCAT6TM=; b=O4i84kE4qM+a92MbsKOCxOfi+v ReiQ8chPX0q94Eful88J0CRbWZaeP3Mu9Wh96gSpdM9GYt9Pdld8D8WoyfU5CpsQXZQCpO5De4lLF sicMMdD85OiL4n31TKVLjzzZK; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:35566 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vj07S-00000001Kst-00o3; Thu, 22 Jan 2026 12:13:26 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/tui: return std::string from tui_get_function_from_frame In-Reply-To: (Andrew Burgess's message of "Thu, 22 Jan 2026 14:30:07 +0000") References: <32f9ecb06cced368b9f6433e9b4f38bad2e61d86.1769092070.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 22 Jan 2026 12:13:24 -0700 Message-ID: <875x8t31gr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vj07S-00000001Kst-00o3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (prentzel) [97.122.114.32]:35566 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLcAjl4XDYkd6cBJZ1/jsdNxwLpLPkZotDhDvFZZTtgM6d/UyK6kJUzHHq0zm/0lN6kRY2h54YgOpRmioKSDXP4aaLA5HCeWaEwJ0pBVQiF2YYLlmyq1 23DRR0+qduOQKUMs+jbryaTXwZBA6zpAfaAf0J7FFjaoHAVuf3MUTnzL3+8xHiiKSuwXS6g/IUIkgKbuGMX8cRfhsPXYa0bA3cI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> I don't think there was anything particularly wrong with the old code, Andrew> but I'm not a huge fan of returning data in static buffers unless Andrew> there's a really good reason, and it doesn't feel like there's a Andrew> really good reason in this case. Definitely agree. I feel like most such spots are artifacts of the C days, where the lack of RAII often meant trying to find a shortcut. Andrew> /* Get a printable name for the function at the address. The symbol Andrew> name is demangled if demangling is turned on. Returns a pointer to Andrew> a static area holding the result. */ Andrew> -static char* Andrew> +static std::string Andrew> tui_get_function_from_frame (const frame_info_ptr &fi) I think the comment needs a minor update. Andrew> + size_t pos = name.find('('); Andrew> + if (pos == std::string::npos) Andrew> + pos = name.find('>'); ... Andrew> + if (pos != std::string::npos) Andrew> + name.erase (pos); Andrew> + Andrew> + pos = name.find('+'); Some missing space-before-paren. Otherwise looks good. Approved-By: Tom Tromey Tom