From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sXRrJD005mkMqywAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 10:12:13 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=ANffy+kh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 821601E067; Mon, 20 Apr 2026 10:12:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD9F71E067 for ; Mon, 20 Apr 2026 10:12:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86E204A9933A for ; Mon, 20 Apr 2026 14:12:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86E204A9933A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=ANffy+kh Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id EEA764B358BC for ; Mon, 20 Apr 2026 14:11:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEA764B358BC Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EEA764B358BC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694309; cv=none; b=oTiIZ/FqE9FuuouRwF0ncluF13eKoBe9qKa+x2vUXXc8GigHzY5CvlCa63KCFSzJWcbMjgigYLhpHJghVNQPAPPRK8RlB62883iA8Ud/j2BYUDLB1b/q3fiM8Xek413Dx2L7moC8BOCOzyB0BlsRiBotGJbB4zHSs8muWIaH/XA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694309; c=relaxed/simple; bh=6bHkmETd0TxPfUOtk4jrAa1Q1BnIwPP8EiTFp2jzAbU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WuZYMQMLOYtmuTIL7YHSHLRWFpRMw4JcwmvaOQMvw1z73qvXZv5SBPcGxghSDL81P8G4OpvwRO0wsXYmCCCgAyHghTZe8aBjh82k2YIGdhbQnC8NukOx3a1wDGu/n1gIRCAoUqdaFDptmpifiTLWSJGqb3btPirS43J/clcEgIU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEA764B358BC Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-42321c8b8f5so2622981fac.1 for ; Mon, 20 Apr 2026 07:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1776694308; x=1777299108; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=mfX3AaYSsCTO7A1UyrmdotAo9A6braAZrJwyOjD5euA=; b=ANffy+kh9Am7cHicXqK5C77XHLi0SxbHoFHaZNhZ0ThkKNfd8S3gmZzCp648V3eauC 48yIx2zPC2mP51YHtY9W5eJ4W2/I+7Zf4Qu6/m2MZreDCo86RRBpnKFOjnsZMgFlsYVk xbI9IVOjSGByb3WkSKEzSYy0UW1nAzHPTiJ+o9tqt4yNDtBh7qA3uel6FJFZeCExVe7S Xexsx9vyL+XFtNqGPF2EC8rvungurq69PFs9Mj3ycJOVf/yOEl0wYHQZK8VaX9gZBSdx VUYNmE7hKJLIgOABh9zKCsosrC2XOw/J6QrEyn5olFqI2MkAsozJ7qCbZNEu8nARHZny WGOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694308; x=1777299108; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mfX3AaYSsCTO7A1UyrmdotAo9A6braAZrJwyOjD5euA=; b=KiobAdsH4tsE9u4J7njBT557J1QE296EAcmWrYYe5Arxpr+ZWxf/sOfVk/4VXmJiTV XzoKu1y8/H5Yb01xTlrGATnHRfSq2Lxq3JZq3jvsDHsb4lQ7B7CDUDwislM7VTlrNFqf Rmk1ps+jbPqPXRFfR+Uv10kL+MUTNorJN4GFBCYevu40QBSimkLQ3oxa6TIzL0Mi6WLi k4GH9Tz2SMSzG8lcJvYwAXqmNozHfeRkrP7XgNiJzY7FD+ePSyZOgcQf1Tl+tVTEKaIH v+KKqNMYPMr+XFj9Kw1mzvsQbDaP4IuCTkZhR1V/vrJk38t2/LnW0pkk27wf9wZyPYCI Q1MQ== X-Forwarded-Encrypted: i=1; AFNElJ/CVSDi8P5IEQNef81nUEq7mdq9MRZhbTK8/Ry3StILMGz7a4Bjs709gPvpsr8JhWX94DVTiPi2INR6vQ==@sourceware.org X-Gm-Message-State: AOJu0Yx5zeymTzW1YZbs0Qc4yZeZQdz53laJjGGBw5K6scbio96nPN6m 3UYp6pC+ih5rvjYVcypN1FFDmryeSB5O4dIJrLtcxMZMv00VQzdYnVp/NPQfhixoow== X-Gm-Gg: AeBDieusF6HgBBjM4GQSpXfXdj34SXESKlSC6Uh7rrzqKfl4oDFK0l8lX+F8AEv7s7g lobrYUFpNth/8i9WBA8RvvrkyalIMxWK44wEH5g5HXbkhkvAh41oDFmzKymI/9rSyUdcT7KV/fE tJpgS4uLTNA8Ue+JmtzTTXElYidwV2+ogj9tON0pPCm72KbAVN6evYk7siQfGbxlVzqbUW5Gkla /WWSQGvZwJscLdpdc6NMHijCOUSIUrAwv06aOS6XN3lJIxzr+Z2ieVJYzONUWS14rjRd9MXPiMM O9i+ijySwT2KmKN7iyMNJOGQodC9wba8RoN1aBkbbML4KFQsTHbA4Wf8sY4mdDM/CbHxaJSLNI5 WuUYKNOYcvhFmHxK31uOd8QgmKX8YLYcLHQMyNb6FNEcr+bqsIFbDbp6tdunZu0Le/QH6MG+2HU YgIvPbUgU5MEg27vQ8t5s1ZqqbWPS0qS5zmxpSpnGlafLuoZIitIkxeQ== X-Received: by 2002:a05:6871:e40e:b0:417:6f:9679 with SMTP id 586e51a60fabf-42a99a809c3mr6614061fac.19.1776694308143; Mon, 20 Apr 2026 07:11:48 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42b934a1a13sm9587421fac.12.2026.04.20.07.11.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:11:47 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] Return void from buildsym_compunit::push_context In-Reply-To: (Simon Marchi's message of "Fri, 17 Apr 2026 16:22:22 -0400") References: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> <20260417-list-in-scope-v1-5-0deb050fc03d@adacore.com> X-Attribution: Tom Date: Mon, 20 Apr 2026 08:11:45 -0600 Message-ID: <875x5lsov2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> On 4/17/26 2:24 PM, Tom Tromey wrote: >> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c >> index 4447923ae3e..2a330655c48 100644 >> --- a/gdb/dwarf2/read.c >> +++ b/gdb/dwarf2/read.c >> @@ -7799,10 +7799,11 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) >> } >> } >> >> - gdb_assert (cu->get_builder () != nullptr); >> - context_stack &ctx = cu->get_builder ()->push_context (lowpc); >> + buildsym_compunit *builder = cu->get_builder (); >> + gdb_assert (builder != nullptr); >> + builder->push_context (lowpc); >> symbol *func_sym = new_symbol (die, read_type_die (die, cu), cu, templ_func); >> - ctx.name = func_sym; >> + builder->set_current_context_function (func_sym); Simon> It might be tricky depending on how new_symbol uses the current context Simon> when reading a DW_TAG_subprogram, but I wonder if we could call Simon> new_symbol first, then pass the resulting symbol to push_context. Then Simon> we wouldn't need to have a setter. If that's possible, I think it would Simon> be slightly better, because it would show that the symbol is initialized Simon> when the context is pushed and can't change. Other callers of Simon> push_context would pass a nullptr symbol. I had looked at this when writing the patch but I concluded that this wasn't possible because new_symbol calls add_symbol_to_list. Ideally new_symbol would be removed and everything cleaned up. But that's difficult. Tom