From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vjMCHjEB9WnngAkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 15:38:25 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=wQlpJoRC; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6A50F1E067; Fri, 01 May 2026 15:38:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBC811E067 for ; Fri, 01 May 2026 15:38:24 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 50DA94AA0974 for ; Fri, 1 May 2026 19:38:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50DA94AA0974 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=wQlpJoRC Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 418014AA0974 for ; Fri, 1 May 2026 19:37:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 418014AA0974 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 418014AA0974 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777664279; cv=none; b=PUlUDm8+womPyLhy4A+4daKWYUWChosOBniM0OkIKDGE+1AWfanGZONKQcAODn9gGPrpWT427uYMgJE0UuWKDYHsgwhIFyA/Rj3ZAtIiNW3BulHYa+G5kUkOWQ49GhXRmWhXvj2RPaXBfIquNo0FjQYVNefia/gO3vzxTcbTPMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777664279; c=relaxed/simple; bh=pLJ1OaUrpAtkmpyvTev5KVs7bdhjOyfhhEJRoHoJg6Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dKK4zRNmcAt3bGHaAjN7kqqCftmXVpqRHTrEu+saml7O/XtY1P0RCDxe2tEIHpWhoLbHYy/52ypgHtaIfbamu3r2HpZD5GlaX9KFW2BJSs7MN4AtZV2IYzC1ff8tJsXZkXvurd8AIhti5osLik/QQXFKVaVM41q8SEKveSx0bbE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 418014AA0974 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id IsFdw51VJrDqVItgTwXYft; Fri, 01 May 2026 19:37:57 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id ItgTwcTu1ZYPjItgTwaYxj; Fri, 01 May 2026 19:37:57 +0000 X-Authority-Analysis: v=2.4 cv=HbMUTjE8 c=1 sm=1 tr=0 ts=69f50115 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=5Ui6k9EUUkS6Q6SC0jYA:9 a=O8hF6Hzn-FEA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qSX3A3QkWPSGOvTS5iaveRbafthzLPiVvJMrH3Rp9ek=; b=wQlpJoRC+WwGB0/xNMjn0JspsI xgcVEx6RaO+X0ZdiYKEtM3A6Tb1H+MzHqypuEPKJN5ji4va2HP2UP8XqwJbhXQyI3/rcj+c3m9o6X aN9w5BDpuPPx3GGskplkg3T/9; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:43316 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wItgT-00000004EBF-1Prp; Fri, 01 May 2026 13:37:56 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 3/3] [gdb/exp] Handle recursive namespace import In-Reply-To: <20260419081236.570600-4-tdevries@suse.de> (Tom de Vries's message of "Sun, 19 Apr 2026 10:12:36 +0200") References: <20260419081236.570600-1-tdevries@suse.de> <20260419081236.570600-4-tdevries@suse.de> X-Attribution: Tom Date: Fri, 01 May 2026 13:37:55 -0600 Message-ID: <875x56hqek.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wItgT-00000004EBF-1Prp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:43316 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEZ6ahOleWC/rMhC+Lvw66wICexDtG5zXdCLkemm0O5TN/hOv9mLke8cRqBvUb3nyH0mf7LDO5n2rrhQpZX34AFdl+arnzVImDaZhYEeD6E9x3OpOmBF X+qygLyGhNOK8c1jeHIZDU1FyiKrHeicmKO6h3f9nfkSEZxCcMglMxDjly5vKteozEXAZ5azPv8pRyKrr+/J7cMZauw7IOvwHd8= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> Fix this by additionally iterating over the super blocks instead of only using Tom> the current block. FWIW I haven't really commented much on the core part of this series because I find this code pretty confusing and I'm not really sure I understand it well enough to do a good job reviewing it. Tom> + for (const struct block *b = block; b != nullptr; Tom> + b = b->superblock ()) Tom> + cp_lookup_symbol_via_imports (current->import_src, name, Tom> + b, domain, 1, 0, 0, In this spot, suppose 'block' is from an inlined function. Then when iterating, I think we'll end up seeing blocks from the enclosing function (the one that was inlined-into). However, that could yield the wrong result, because the inlined and inlined-into functions could come from completely different namespace contexts with different 'using' directives. Tom