From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 00/10] [gdb] Add some missing i18n support
Date: Tue, 09 Jun 2026 11:01:03 -0600 [thread overview]
Message-ID: <875x3rfy28.fsf@tromey.com> (raw)
In-Reply-To: <20260607060041.410491-1-tdevries@suse.de> (Tom de Vries's message of "Sun, 7 Jun 2026 08:00:31 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> I ignored internal_error and internal_warning calls, because I think their
Tom> strings don't classify as user-visible strings.
Agreed.
Tom> I also ignored calls like gdb_printf (gdb_stdlog, "Warning: ..."). I wonder
Tom> if these need to be rewritten to use warning ("...") instead.
I think so.
This all looks good to me. Thanks for doing it.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-06-09 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 6:00 Tom de Vries
2026-06-07 6:00 ` [PATCH 01/10] [gdb] Add missing i18n support to error strings (part 1) Tom de Vries
2026-06-07 6:00 ` [PATCH 02/10] [gdb] Add missing i18n support to error strings (part 2) Tom de Vries
2026-06-09 16:56 ` Tom Tromey
2026-06-10 6:10 ` Tom de Vries
2026-06-07 6:00 ` [PATCH 03/10] [gdb] Add missing i18n support to error strings (part 3) Tom de Vries
2026-06-07 6:00 ` [PATCH 04/10] [gdb] Add missing i18n support to error strings (part 4) Tom de Vries
2026-06-07 6:00 ` [PATCH 05/10] [gdb] Add missing i18n support to errors strings (part 5) Tom de Vries
2026-06-07 6:00 ` [PATCH 06/10] [gdb] Add missing i18n support to warning strings (part 1) Tom de Vries
2026-06-07 6:00 ` [PATCH 07/10] [gdb] Add missing i18n support to warning strings (part 2) Tom de Vries
2026-06-07 6:00 ` [PATCH 08/10] [gdb] Add missing i18n support to warning strings (part 3) Tom de Vries
2026-06-07 6:00 ` [PATCH 09/10] [gdb] Add missing i18n support to warning strings (part 4) Tom de Vries
2026-06-09 17:00 ` Tom Tromey
2026-06-07 6:00 ` [PATCH 10/10] [gdb] Add missing i18n support to warning strings (part 5) Tom de Vries
2026-06-09 17:01 ` Tom Tromey [this message]
2026-06-10 7:03 ` [PATCH 00/10] [gdb] Add some missing i18n support Tom de Vries
2026-06-10 13:21 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x3rfy28.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox