From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WbdVLGE8g2p8RC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 12:52:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z2dcP+xU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B1B1D1E033; Mon, 17 Aug 2026 12:52:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C99F1E033 for ; Mon, 17 Aug 2026 12:52:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC2664BAE7D2 for ; Mon, 17 Aug 2026 16:52:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC2664BAE7D2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z2dcP+xU Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id AC3574BAE7E8 for ; Mon, 17 Aug 2026 16:52:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC3574BAE7E8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AC3574BAE7E8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786985523; cv=none; b=n2P/8fWkvD8E8ElvMiawV8fcFo6TKhFu0QRDDrkuw1Ag8wap29duQGGIxDu+WKnFtwCRpB4M06DNgawyeS6gt1w868gFNL28MdDJOb/1Wy9/qV08JcCE99sHdmiZt1qe5sz8Lk/OzySICKCncXyx4iBCV9kv83cSB6VpJvz4Eyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786985523; c=relaxed/simple; bh=CdgNEnyH3ZmDrIqtuSK+m58klaGiEovRqZVAbfl40AE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=w5iK3u7c1XHGZAI8CC5zlM9Za+f+Q9Ngo4cXTr6O7lGtqBW0bqeyhYPogYCUWnCnZTL+rOnZXAtJ0vr4qEqtu7+fkI6RGzRVqQEqx4cy5PzLBV13qsAZ2BChZafeuXqAJEGd+HBmw8+SVT0OGLDuNwIdVqTyoXSgbMB5ZCXK+l4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Z2dcP+xU DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC3574BAE7E8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786985523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FaAFSvofU8TdGF1E2a8Nd+l2b8/ndYv2oy6lv1haj84=; b=Z2dcP+xUUFcmXfzkhzap8pNSt8bD2DYkdjqBCwbWjsFvf1Aheh4hY/o705ogttUtpG9LrN 4zrG9Bb5Hrwb8jSl0hVQtT2g+tVJGgi4KkRbJ5UojCsc962iRR9+3QzDew2/rry8jTOtii Fqmr0lk2LdfOZIJhmSTb21jK3X5gMfk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-85_sFpPdMFChh7iT2V8O3g-1; Mon, 17 Aug 2026 12:52:01 -0400 X-MC-Unique: 85_sFpPdMFChh7iT2V8O3g-1 X-Mimecast-MFC-AGG-ID: 85_sFpPdMFChh7iT2V8O3g_1786985521 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47f8398ed9fso3013616f8f.0 for ; Mon, 17 Aug 2026 09:52:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786985521; x=1787590321; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=FaAFSvofU8TdGF1E2a8Nd+l2b8/ndYv2oy6lv1haj84=; b=doZp2esXb2Vvna5w+izaquOkdXvBydWWsz8zzJoA719xZun8djtq1OI01ivwALsubR x3yCHBe0QC3tQloswU10I7tJHGOFQIkFtVK5LtJd6I6ld4glxjYfajwYjcItrWq1wf+s 3L9sZi2A8tkb7ZgHhYGB2gc1zUzDP1ppAH1G5+FqVXsUssciC2s1obQQrVYFxDAHobyU tB5tu1Mcuiu53OY4DKOz0HMaLHJgBYu7m9tDfRtSL6eG8L7TWM62odlzHPaIXZ6WCYME R6q921YPRvO/XJCFWmp7co60wvUPj82xGydTVhede9YfuoYM3AjJXn6gzkbGVG1NhOso sUUg== X-Forwarded-Encrypted: i=1; AHgh+RphkOTQUT4ekY0YBFrhpgQL6cl6TXonc7kQoSwnxQMm/Xr93tEXEiDIV0urfaC0XRAqA0mQNR4uXtJuGg==@sourceware.org X-Gm-Message-State: AOJu0YzdwNUTph0CSoM6NIX3kiQJ5/EAX8DTnLyLbQrgCveaiz/XDLEF cCRteq+0nqo/icFwQzZtHMgHGG0liBAwZRTNsXDrJNIXFoKSijiKlqXLCPAFgT32+ii5nae5H8J WvR45fyBsXYUiukMbwIW8bZ4lSJDUDgMp2c8ojhWzxmbQ3ayaUTj05mOKoiemmAY= X-Gm-Gg: AR+sD13S9qHG8Ntgk1aB8fPDPbmTUk8ejiShFtDwmgnHqPK3kReSRkto/loz1+mUfIw 1DIdmwoJh7I3+05XxyNQptJsqathJMeHLrdlTk5Ow9PnCm7dzhya1NZQL+HpqWsR+NSk57cvTsR kmVcG5oA3gzWIhdGaT4f7yQC2Gmd0Sv0CMav6GSr+dT4sZQGKnfnn1NW1X8EwB8puxnD1r7Uzhy Cw0lCXlSFouGYm0OFVNJcsMt4kqE02ZD8xQqYLlQxHPDP3gfgXTcHPVQ/hQjdUxu41SnPBywKXN keEITaBD/If1SxgEbJrmVCGObSgKGS+SYeiEJrBSCTwd7UDwrYXTqyhY/RBB6Ih9JSQ1/BpaqdL d5mypRlIp2UqB2uReLK0= X-Received: by 2002:a05:600c:5613:b0:493:c47f:3c55 with SMTP id 5b1f17b1804b1-49987937672mr286288125e9.5.1786985520686; Mon, 17 Aug 2026 09:52:00 -0700 (PDT) X-Received: by 2002:a05:600c:5613:b0:493:c47f:3c55 with SMTP id 5b1f17b1804b1-49987937672mr286287655e9.5.1786985520260; Mon, 17 Aug 2026 09:52:00 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961767f5sm141457345e9.9.2026.08.17.09.51.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 09:51:59 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 13/13] gdb/tracepoint: remove uses of sprintf In-Reply-To: <20260817151646.152571-14-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-14-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 17:51:59 +0100 Message-ID: <875x183d1s.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 06rYfdjL3wkljPbUzI_0r31rvTF8DI7YnSnzZjZ_UDA_1786985521 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get some: > > /Users/smarchi/src/binutils-gdb/gdb/tracepoint.c:1196:4: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations] > 1196 | sprintf (end, "M-1,%s,%lX", phex_nz (m_memranges[i].start, 0), > | ^ > > Replace them with xsnprintf. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: Id3ec76c47e5c0091fa3a028e36063b2115378e7e > --- > gdb/tracepoint.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c > index 798bb9a552d8..932a8f557e44 100644 > --- a/gdb/tracepoint.c > +++ b/gdb/tracepoint.c > @@ -1164,6 +1164,9 @@ collection_list::stringify () > gdb_printf ("\n"); > if (!m_memranges.empty () && info_verbose) > gdb_printf ("Collecting memranges: \n"); > + > + char *buf_end = temp_buf.data () + temp_buf.size (); > + > for (i = 0, count = 0, end = temp_buf.data (); > i < m_memranges.size (); i++) > { > @@ -1193,11 +1196,12 @@ collection_list::stringify () > "FFFFFFFF" (or more, depending on sizeof (unsigned)). > Special-case it. */ > if (m_memranges[i].type == memrange_absolute) > - sprintf (end, "M-1,%s,%lX", phex_nz (m_memranges[i].start, 0), > - (long) length); > + xsnprintf (end, buf_end - end, "M-1,%s,%lX", > + phex_nz (m_memranges[i].start, 0), (long) length); > else > - sprintf (end, "M%X,%s,%lX", m_memranges[i].type, > - phex_nz (m_memranges[i].start, 0), (long) length); > + xsnprintf (end, buf_end - end, "M%X,%s,%lX", > + m_memranges[i].type, phex_nz (m_memranges[i].start, 0), > + (long) length); > } > > count += strlen (end); > @@ -1213,7 +1217,9 @@ collection_list::stringify () > count = 0; > end = temp_buf.data (); > } > - sprintf (end, "X%08X,", (int) m_aexprs[i]->buf.size ()); > + > + xsnprintf (end, buf_end - end, "X%08X,", > + (int) m_aexprs[i]->buf.size ()); > end += 10; /* 'X' + 8 hex digits + ',' */ > count += 10; > > @@ -2816,11 +2822,14 @@ encode_source_string (int tpnum, ULONGEST addr, > { > if (80 + strlen (srctype) > buf_size) > error (_("Buffer too small for source encoding")); > - sprintf (buf, "%x:%s:%s:%x:%x:", > - tpnum, phex_nz (addr), > - srctype, 0, (int) strlen (src)); > + > + xsnprintf (buf, buf_size, "%x:%s:%s:%x:%x:", > + tpnum, phex_nz (addr), > + srctype, 0, (int) strlen (src)); > + > if (strlen (buf) + strlen (src) * 2 >= buf_size) > error (_("Source string too long for buffer")); > + > bin2hex ((gdb_byte *) src, buf + strlen (buf), strlen (src)); > return -1; > } > -- > 2.55.0