From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CTqLKINJwGkZmzQAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 15:56:51 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=hd1Y1G0w; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9EE541E08C; Sun, 22 Mar 2026 15:56:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 01DBE1E08C for ; Sun, 22 Mar 2026 15:56:51 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 6B56E4B9DB6A for ; Sun, 22 Mar 2026 19:56:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B56E4B9DB6A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=windriver.com header.i=@windriver.com header.a=rsa-sha256 header.s=PPS06212021 header.b=hd1Y1G0w Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by sourceware.org (Postfix) with ESMTPS id 71DBA4B9DB55; Sun, 22 Mar 2026 19:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71DBA4B9DB55 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=windriver.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 71DBA4B9DB55 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774209380; cv=fail; b=xqFU3uY78S1GlXCMWOLYWv+DShnIIC6Yf52QcP+REkHWLzYQ5/ZTqF3FnFPkaTY58tAaVrA4qh+5BkWItdBOcPkYgAL4OKovKA+LziKXPO9GO5lMaEIbiCvGA2uqaYO93LobusUSHI8j083j8xpWPE/2pHZWLs+a8/yE8ntJD18= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774209380; c=relaxed/simple; bh=pde4dLVuQb2JFe8lqhJMOVDX4YQbT0a6pJ2O3ngrf7s=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=RAxIjw5Jki/ylScbN0TQuaa6wk93nTx8IXMZUXo1p4wFKBHJnM/uUrmTfdlGzFykiUCVYSo0CNsrfcoo3X11HMIWUEOawVdpfZF9ydcmUkzF6Tig040BePSSjAcQOv+na8oDyScvdgn9PcUmk3FEf2aEIpOAnFLlMIEKumA9p7s= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71DBA4B9DB55 Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MJo2A22729770; Sun, 22 Mar 2026 12:56:12 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :in-reply-to:message-id:mime-version:references:subject:to; s= PPS06212021; bh=lIYMawCFD2AvPBS2dvM3pvbqClxJisdjoOnUbXRzLjc=; b= hd1Y1G0wB6LH8KMGZ5xj/+mg1ydgKwRCsW2q/yE/gy+5018ayElI1YUSi4XCoVrT xIf/Qm5OnpjGzKWZZKiZRZKFRR+dTA8faJfC75VNDmJbYQq+LI5/KoMt/CftaHGO WBiEuSmDiq0vGdp0RGRVLBRee0YyXD31NzhPynIiXX/nnqoLMbAeEvnANrG4Xn/X /emC2osIAhKbyWhQhdWqG/poInVzHCXdfvDyM/nFqBbnSjYGB5RyhUV9LTfLmXp+ uevRnPCyciLLnonvdAW4xtx4QEVYchRgSPlzTy6mLG9ALcmR+rdmdKxuYcS5qcup 7ZWuU0U5fSUxiJIpC8qcsQ== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013030.outbound.protection.outlook.com [40.93.196.30]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4d1pky90x5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 22 Mar 2026 12:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ktvb40ZFAV4abMKwEWgRseeYu3JptBWB/gvtoROnI5sT3/S3Eir3FKUxERSvfcHhL5xhsEgKn94551imr/9UxM/8v26WOwC3Mp/f2I/4fKh1bK8ffs7wCTLai897F36R9Sk3pN8YszJnn/ikUqY9cZhDpecOln74vuJj+8c3LsDU/D79vkDi87YUiHtEdncJuziLC6uNE3azoEOK9GWbCGdZ78p2fF2unLkFVDOgzF1NmbOH2fSbztwnQnu7fnp8anmssUl1Lkt4kDoTlnRLD/JHO/SZXTfi7UDYbkfoggJBLBS8Ab4TkeJSfuM/LihNgq3IQeXQceQAwX2CoXVhTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lIYMawCFD2AvPBS2dvM3pvbqClxJisdjoOnUbXRzLjc=; b=AX1wfbvpsFz/8mKfpQ1cg4Q5Ag/j+Jd0brQoyUPdhEQhz97hsbsOEoE4E/Ab5DL1ojgsb2fCitcvK3IKK48Uyz1970tLPqTPV9YU1C5WyZlPWusS92hT7JKnqdWjp65LDiY1yAGFPIzsyxTrc7ZH+wfvENBnA74n+zHauCxoMnqeom8vX6xginaLSXOp9M6Pzlf1lj4pVw++g5mX8J7IRvW7w32sl6jEp6ICOvqGFET+3ff79chO1+XxqMTCILNEYCkmnDLOPmDJzKh2uHsIc0B72PqINmisrBZNSHYMxyiDYlGDtzRgjHITuoXvCf13loMOgt5lxuRryLFJmUCxPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) by PH3PPF2B89F77E0.namprd11.prod.outlook.com (2603:10b6:518:1::d11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.9; Sun, 22 Mar 2026 19:56:07 +0000 Received: from DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f]) by DS0PR11MB7901.namprd11.prod.outlook.com ([fe80::4293:7c4b:a0b5:eb5f%3]) with mapi id 15.20.9745.019; Sun, 22 Mar 2026 19:56:07 +0000 Message-ID: <87596303-eabc-4489-ab49-5d56849717c1@windriver.com> Date: Mon, 23 Mar 2026 01:25:56 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] PR gdb/33747: gdb/ser-unix: modernize Linux custom baud rate support To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Kevin Buettner , Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com, schwab@linux-m68k.org, tromey@sourceware.org, Simon Marchi References: <20260312210106.880833-1-sunilkumar.dora@windriver.com> Content-Language: en-US From: Sunil Kumar Dora In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MA5PR01CA0240.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:1f4::12) To DS0PR11MB7901.namprd11.prod.outlook.com (2603:10b6:8:f4::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7901:EE_|PH3PPF2B89F77E0:EE_ X-MS-Office365-Filtering-Correlation-Id: e1ee2f6c-f0fd-41b6-d854-08de884d0e7f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|1800799024|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: f4m+80Vq2P2XQbrYTrbKU2eJqQvaYzszKLSdcDsIJQJGfydVjqRrNVxQaQdJnExTBqUDz8y/N8OKO79T/nuDjxVNHpjpJb5Gk4MBU+L07qJ5+6hnEa62VuJ86M670ZAWaxU5185MNXVN8DotYjW8twM/ozzjn6cTJ3nClx1joL/jzlnDs7N489elYavdUhFMd67xhfhvqJIfk5cRp2leJSiRmdtHhrBXjYz00eRVSA0Tbo6UTl1cfq57cNfkvl8WUswDUKmT8tltZmD8PYKgjZ0jm34lIqeDoE8/dXLkHTNyMTWPpyeXpemjxmrHusvTMArRgMQp/Zetmopq7aXIEzLpdGb8EAlSn+sXAH8cSGHrZC6U1Zo1zv+P2n+t9rhCHOmGrvplt5J5WX8N5PE/SDlKlJ6QoNyH7DVrwHAtHx9h9lcMB6LZG3p0o0gR6HyBi0TfJVDyxjDKxFuDsVPt7LATT/QpQi3mHz6kQrtgE/rwfka9ajY+eiGax2F1M3o0e2X33RCmOl4QDs/3HI1A49G53R7CRpXfo8DF+KEyyywvnadcXaMJKDJ8sERkiPAg40Tgjb3joBAklkxGlwTLMP1tC3eBs3pUDJu/RhXCdEGK3hWC3hygWNcalgGQXG2xPt6xP3JalXOfJpUrX8kj4atLX0f8ONKlMS22XofFDgGeDJsyX5k/L6h0D8xAPLwbyFnIGTkQhToslAQw/EqzKyQLMX/DnphUR6iQSaA2lKo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS0PR11MB7901.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(18002099003)(56012099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGVQYVMzeTQrWDllS05TMmVTMXUySm05b1pXV2FMTEd0bU9xK2lPTmw5aWJE?= =?utf-8?B?b3I0azJBYmk0alA3akFJU1FZbnhNL3NFeFFSV2hSK1ZmQXpGZG82YWwvWlJ2?= =?utf-8?B?NkdqVlJEUjdJZmZEa2R3ZFVrZ0w3Y2lnZWd0UEsyYkprckJFK1MyWVk2Mk1P?= =?utf-8?B?R3NRTDNPdnRreFJBRzFrKzd2SEZaTmxNQmRsZFRDYlVvcW1GVmZkZTlNaWtT?= =?utf-8?B?OHJkQWdjUmNJQkYvZEpaeVh4M1N1NVV4VE0xY1MwTVh5SEh3T2RRaVpZbEZX?= =?utf-8?B?R0VhRGZzeUZzaTNlaytWRU1ldW1zdjloVHF4amlMSHdqOXJ1T2dYM3pIb3hQ?= =?utf-8?B?Ujh5QStZRmY5bzZSOGYxdklKN2poZ21NOXpYNGhFZzBuYmF1ako5WDBIdjcw?= =?utf-8?B?WWtCRERsRkNFWDIyNzZEUHAwYnFvNWZiMDFWc2xNbHdHbGVwWWJmb1dUbERY?= =?utf-8?B?OXduVFE1bjRZcHJ5RlpsTHNtUnk4c2NqRWVEVDgyWGhnMDRERGh4NU5HWW5P?= =?utf-8?B?SEtTUVdQSERnbjBFNHJsRFgrdUR3UXk0N3cwQlhWOWdwME1YTXJtcFg0cjFt?= =?utf-8?B?MzJYbllSb0dack92VysrNDRvZUlwbEJFaUp6VFZYaDJsV2lYVGFMQ2k5YVY0?= =?utf-8?B?MGhiQzZHZzYwRFlVNE9VTUFhSnBoSFVuTmpLNU1UWWhyd09hSWpFWk4yWU5p?= =?utf-8?B?YkZLdXJVY0YxQzlXTXNjUE1DaG9qZkorVWpod3h5MGcxRGFlOURoZmVkWXp1?= =?utf-8?B?UjJaaHR1amkyV3NxaG15RVhGS2NTQ0hsYkxKTEZqS3JNN0FHUDU4ZmkycU0r?= =?utf-8?B?dEJOUkppMlphRHBxMFpuc05wUVkwemN1OWt2QVZZdjlGZ21pbitUdTViYS93?= =?utf-8?B?cS9YVWNyVlQxdURwa3MwUWwrWDl4Nm1abGVjWnF6YWFzMXNiWnM0cWVPdWJt?= =?utf-8?B?Ymx1bHczS3hEc2JsdDBSS3paWmZNMmNpQ2RqZkJyWk5OWGh4THZtdS9EbHVu?= =?utf-8?B?UGdSdDBVSW56dkdDNDZwRWFDcVkzWmI4M0JNckVFYXVLKzVoL2M3TkVZSWhX?= =?utf-8?B?ekx6UnY2dVB3aWRIejRQaEE3OWU3UW1NcWhrVUVQZlQyMkJNdEJ5WlpQQldP?= =?utf-8?B?NzZDUmxSc05FYlJnYkIrd1prQXdFam5RblN4UC9SclRRK2N0UGlWTmF0aGZT?= =?utf-8?B?V3I3WFg0cFFUOUIxeW44aGNiLzRjSmpWSkVKTGhkNVZPNEQzMkxsaVJ6ZEJP?= =?utf-8?B?NnMyMEtTeks1RGJUM1JySXJ0UTF5eHpHWURETzZ0N093TmRqOG1KMjJuQUFq?= =?utf-8?B?NDVDNldQeEs0bVg2YXMvNXJtaXRyTHJTRWlkMWtSMUIzcElUU2JUS1cveFVY?= =?utf-8?B?YzZuZitERGdNWjlwWDZZeE8zbWxyTFdXYmh5bjlXeTRNcFVvaGl1Zk9WaHZK?= =?utf-8?B?TDdSdE9rMUdoSlVKajRTSjJqRDFlUVlxbFVoZ3FEOWZZZy84OFFjWWc1MkxI?= =?utf-8?B?WFdBRTM2YWYzODJUdE1uSlpVayt6dU80V3RqSldrTGlNSVY5c0dZQVR0MnRs?= =?utf-8?B?c3llM0JpRlhpekNrcVRYakYzTytGbllreDB2d1A1NlNjNEhpd2tFRXczVTBB?= =?utf-8?B?ck1OZDRjQjNWWjBUeVNDdjVqampVc0JjMUNiS2gwdkZiTTN4SkVmT2RodUJP?= =?utf-8?B?S3o3ZDFCNlZxaCtDQ012dGJCMWg5VjlodmpPOEM2TUxDMHVtQk1WcjFXY2hC?= =?utf-8?B?M21mdEtvZzIyNVRyOE1RR3ZnVFQ1ZnY3Nml1VjZUc01OSmI3TzhFVzJIMXFS?= =?utf-8?B?Nlo3aXVjb1RJOFozRzYyWENES0FMbkl0SlN5R0wrVXpTYlJrZHlHTTZXU3pH?= =?utf-8?B?S0VIOUxqUE4vanlucXlHcWtzMDhsWFRmdlBzWDg3UlFIZTFUU3VXcGJOa3pn?= =?utf-8?B?WHVnaE43Y0JGamFxVmRLeWNCdDVXZVNicjVTK1RFcDA4V1loOHVoSGEvV2pL?= =?utf-8?B?N0tmZXVQMVV6WFE5c0JBVlJUR0M1OUpBRnlpSTc1aWtFcVd2QU03b1BTdTBQ?= =?utf-8?B?ZTBDQmVRYkhZcWp0RllXcWJEcTNHblBjVVgzUjF0bkZqUmVvZFZvZnBxWDBQ?= =?utf-8?B?K2dnUXhCb2pvTy9nclB5b0UwNWcxNkZWb3JQU0NibGJzODFmQ3BLa2JKcnJP?= =?utf-8?B?bHREYjNmMlBBTld4Y0hERFQrS041TlJNREc2dmUvVGYyUFRjb2J5bXltNTZU?= =?utf-8?B?RG5zMEh0WDBIcWhtcUFiZ1lGemF3K2dLRGFjSTdndFI5RDA3R0lXUTBIbzRk?= =?utf-8?B?d05GUnVjZkYwdlJ6V29YRzJ5TVhUZWJyNDgra1FSbDZRb2srSUVkeUp6RC9u?= =?utf-8?Q?t+NFSUBZtUG8REa8=3D?= X-Exchange-RoutingPolicyChecked: GzgScfCdCZBLyQ9+hw+u3cGI9lQfbpBNhuYxRzIhxqMWFHVf0gc4eWNBITA8ZYYJXF9UQgNRPEEAT8i25z55rDGhR5pqLUPjHbCcaE9z6OVSouSL7NjePEJJtyXeu/ANS2k6JC02v5i+L944TyiSRjfM3mpmzD8LLK1NmGOq19HXbTIYWz3KKXpPpFuJxSB5wV69c/4pm5xX8vPgENXf9slVIQveYzQ1KS8/bM+CRBOPgSP0sXdw0xyf1zo8P9dzNhEcdpcZ0LeBUpuDye60gMJgaSE20qLF7Qojae8uHmqy619RkOqFm7mFcFNjKj4KcYoPSw9U+lt+LsNuqn4A9w== X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1ee2f6c-f0fd-41b6-d854-08de884d0e7f X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7901.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2026 19:56:07.3543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jNOYrGEHMCpFTT8bI1Mzd6OSh0DJYJStr5B8o+yoA1YEGYG75GetlVowsJdckoeVvW3U0vj/BcYqHZXrrSqXe6HmY1SOV9JaOPznoHtu15g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH3PPF2B89F77E0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIyMDE3NCBTYWx0ZWRfX74iBmjQvAjyc A3BjcG8EK8dgaAv60cdgPR0260ydOl+mJ9gBGFtS1WtszK0pYEKSU2Ep0tEHW51lpCJpCDo2K87 D1dyMbpqcBgbROJyu8gq1A2QxiNdxXTOksvDgSr/apVRnXFFLK0fQ2GkghE0hMBz8EhwNMhP7q4 SKfzGZAEGAii0cvVjBqT0uqpiz5xrsCQz8rzEo6YrSWtygMlZlZ4xOvFEbGB0rkmLZrYLUyg+Zk Nq+lfzUNWaZPr47yrhm0LKxrd78gVkJJSe9oad7lFLm/zq0jvT9IUX/wvkZXaGQAB1ccUeL93Ec lwaUNjTfzRdns+vv3gEMLz2YzP9zdbxBUBf8a7uXHD/Bw0fYhFvFUxVHBKWV7k32L0BkgeUZe3J xbVTIdlT9zPozhAaMqXwWoJWenS3y90WNGk2Y+j0mNJ2cg79SAaV32GNxKBRW0mBBSX775zR1ww BtlPglaNjLaTLQVhGqQ== X-Proofpoint-ORIG-GUID: aV_KVn2dYOt0v6wKFRc_ioo2uNagBq7C X-Authority-Analysis: v=2.4 cv=Scr6t/Ru c=1 sm=1 tr=0 ts=69c0495c cx=c_pps a=Ky5N4DqHy2xmpABslddG/A==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bi6dqmuHe4P4UrxVR6um:22 a=HK-ge7EqtdluswH-FwHe:22 a=t7CeM3EgAAAA:8 a=frD8dQ9u4xrSCOQaOrIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-GUID: aV_KVn2dYOt0v6wKFRc_ioo2uNagBq7C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-22_06,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603220174 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks Maciej. On 3/20/2026 6:54 AM, Maciej W. Rozycki wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Thu, 12 Mar 2026, sunilkumar.dora@windriver.com wrote: > >> diff --git a/gdb/ser-unix.c b/gdb/ser-unix.c >> index c295a9c5ba1..a15f4cc2162 100644 >> --- a/gdb/ser-unix.c >> +++ b/gdb/ser-unix.c >> @@ -510,36 +510,59 @@ set_baudcode_baudrate (struct serial *scb, int baud_code) >> >> #if HAVE_CUSTOM_BAUDRATE_SUPPORT && defined(BOTHER) >> >> -/* Set a custom baud rate using the termios BOTHER. */ >> +/* Set a custom baud rate. >> + >> + Prefer the POSIX cfsetispeed/cfsetospeed interface when it accepts >> + arbitrary baud rates. Otherwise fall back to Linux-specific termios2 >> + (BOTHER) or legacy termios interfaces. */ >> >> static void >> set_custom_baudrate_linux (int fd, int rate) >> { >> -#ifdef TCGETS2 >> - struct termios2 tio; >> - const unsigned long req_get = TCGETS2; >> - const unsigned long req_set = TCSETS2; >> -#else >> +#if defined(HAVE_CFSETSPEED_ARBITRARY) >> struct termios tio; >> - const unsigned long req_get = TCGETS; >> - const unsigned long req_set = TCSETS; >> -#endif >> + if (tcgetattr (fd, &tio) < 0) >> + perror_with_name (_("Cannot get current baud rate")); >> + >> + cfsetispeed (&tio, rate); >> + cfsetospeed (&tio, rate); >> + >> + if (tcsetattr (fd, TCSANOW, &tio) < 0) >> + perror_with_name (_("Cannot set custom baud rate")); > It doesn't appear to me this code should be wrapped in: > > #if ... && defined(BOTHER) > > or for that matter be a part of `set_custom_baudrate_linux' (which AFAICT > should be left alone, or please point me at what actually you have changed > there that is not pure code massaging) as this is now platform-agnostic > (and I believe GNU Hurd has always supported arbitrary baud rates using > this interface). I'm leaving it up to you to come up with a name for this > new variant of the function. > > Also ISTM that HAVE_CUSTOM_BAUDRATE_SUPPORT now also needs to be set if > HAVE_CFSETSPEED_ARBITRARY rather than relying on BOTHER to be defined as > well, which may not necessarily be the case (cf. GNU Hurd again). To clarify the change in set_custom_baudrate_linux: on musl-based systems BOTHER is visible via , included through the HAVE_ASM_TERMIOS_H path in ser-unix.c, so the function does get compiled. The #else branch then fails to compile because musl's struct termios exposes the speed fields only as private __c_ispeed/__c_ospeed, not as c_ispeed/c_ospeed. Following your suggestion, the fix belongs at the macro level. Requiring HAVE_STRUCT_TERMIOS_C_OSPEED alongside BOTHER in the HAVE_CUSTOM_BAUDRATE_SUPPORT guard ensures the Linux path is simply not compiled on musl systems where those fields are unavailable, leaving set_custom_baudrate_linux completely unchanged. In V4:   - set_custom_baudrate_linux is left completely unchanged.   - HAVE_CUSTOM_BAUDRATE_SUPPORT is updated to require     HAVE_STRUCT_TERMIOS_C_OSPEED alongside BOTHER, so the Linux     path is not compiled on musl where struct termios lacks those     fields.   - New independent function set_custom_baudrate_posix(), guarded     by #if HAVE_CFSETSPEED_ARBITRARY, outside the defined(BOTHER)     block, covering systems like GNU Hurd.   - HAVE_CUSTOM_BAUDRATE_SUPPORT extended to also fire when     HAVE_CFSETSPEED_ARBITRARY is defined.   - The #else error() fallback is removed. Unsupported platforms     are already handled in rate_to_code() and     hardwire_setbaudrate(). V4 will be posted shortly. > >> +#else >> + error (_("Custom baud rate not supported on this platform")); >> +#endif > This shouldn't be needed as this code is not supposed to be ever compiled > if !HAVE_CUSTOM_BAUDRATE_SUPPORT (IOW don't set the macro instead if the > conditions required are not met). Fixed in V4. Thanks, Sunil Dora > > Maciej