From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88351-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4315 invoked by alias); 29 Feb 2012 18:04:35 -0000
Received: (qmail 4306 invoked by uid 22791); 29 Feb 2012 18:04:34 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Feb 2012 18:04:17 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TI4HTQ001514	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 29 Feb 2012 13:04:17 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1TI4G0g026879;	Wed, 29 Feb 2012 13:04:17 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1TI4Fat026466;	Wed, 29 Feb 2012 13:04:16 -0500
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 04/14] -Wmissing-prototypes: Python.
References: <20120229161628.23918.51354.stgit@hit-nxdomain.opendns.com>	<20120229161737.23918.81678.stgit@hit-nxdomain.opendns.com>
Date: Wed, 29 Feb 2012 18:09:00 -0000
In-Reply-To: <20120229161737.23918.81678.stgit@hit-nxdomain.opendns.com>	(Pedro Alves's message of "Wed, 29 Feb 2012 16:17:37 +0000")
Message-ID: <874nu9plcw.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00723.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Most are obvious, and I think including the public "python.h" in
Pedro> py-breakpoint.c and py-value.c is the right thing to do, given that
Pedro> the functions in question are indeed public and to be used by core
Pedro> gdb.

I completely agree.

Tom