From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2288 invoked by alias); 8 Mar 2012 18:17:48 -0000 Received: (qmail 2275 invoked by uid 22791); 8 Mar 2012 18:17:46 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Mar 2012 18:17:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q28IHORx008218 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Mar 2012 13:17:25 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q28IHNEL015501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Mar 2012 13:17:24 -0500 From: Tom Tromey To: Chris January Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix incorrect use of strcpy. References: <1331216484.2742.7.camel@gumtree> Date: Thu, 08 Mar 2012 18:17:00 -0000 In-Reply-To: <1331216484.2742.7.camel@gumtree> (Chris January's message of "Thu, 08 Mar 2012 14:21:24 +0000") Message-ID: <874ntznej0.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-03/txt/msg00280.txt.bz2 >>>>> "Chris" == Chris January writes: Chris> The strings passed to strcpy may not overlap, but &p and &p[len + 1] Chris> clearly do. memmove allows overlapping memory area. This is ok. Thanks for doing this. I think you should get started on your copyright assignment papers. Your current patches are probably under the limit, but if you send more then we'll need these. Contact me off-list and I will send you the form. Tom