From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21211 invoked by alias); 8 May 2012 17:19:36 -0000 Received: (qmail 21193 invoked by uid 22791); 8 May 2012 17:19:33 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 May 2012 17:19:18 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q48HJ3v3007973 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 May 2012 13:19:03 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q48HJ24x006988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 8 May 2012 13:19:02 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFC] choose symbol from given block's objfile first. References: <1336430581-11262-1-git-send-email-brobecker@adacore.com> Date: Tue, 08 May 2012 17:19:00 -0000 In-Reply-To: <1336430581-11262-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Mon, 7 May 2012 15:43:01 -0700") Message-ID: <874nrqvbeh.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00238.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> But I also believe that this is a useful patch, because I think Joel> that the answer yielded by GDB using this algorithm has more chances Joel> of returning the symbol that the user actually meant. I agree. This change would make gdb's behavior less surprising in some corner cases, and I think it is hard to argue that people know or rely on gdb's current behavior. Joel> This is only a prototype at the moment. It fixes the problem while Joel> not causing any regression with the testsuite. I am wondering about Joel> the loop over all objfiles callling lookup_symbol_aux_quick. I think Joel> I would need to apply the same treatment, in case Joel> lookup_symbol_aux_symtabs doesn't return any match. But I'm not sure Joel> why I'd need that... Yes, I think you'd need this change there as well. gdb should end up in the lookup_symbol_aux_quick loop if the symbol in question is in an unexpanded psymtab. In this case you want to be sure to check the block objfile first. Joel> ALL_OBJFILES_STARTING_WITH Works for me. Tom