From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 351 invoked by alias); 8 Nov 2012 21:57:18 -0000 Received: (qmail 341 invoked by uid 22791); 8 Nov 2012 21:57:17 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Nov 2012 21:57:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qA8Lv4X1020554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Nov 2012 16:57:04 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qA8Lv2SG009644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Nov 2012 16:57:03 -0500 From: Tom Tromey To: Keith Seitz Cc: "gdb-patches\@sourceware.org ml" Subject: Re: [RFA] c++/13615 References: <505119AE.6040401@redhat.com> <87sja4wlqt.fsf@fleche.redhat.com> <506F38C2.4050107@redhat.com> Date: Thu, 08 Nov 2012 21:57:00 -0000 In-Reply-To: <506F38C2.4050107@redhat.com> (Keith Seitz's message of "Fri, 05 Oct 2012 12:45:06 -0700") Message-ID: <874nkzhi6p.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00217.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Yeah, the two are rather similar, but not exactly. Nonetheless, with Keith> much hair-pulling [I haven't much left!], I've been able to modify my Keith> original patch to fix the problem reported in the above thread. [I did Keith> not use anything from the suggested patch other than the test case, Keith> which I've updated a bit.] Keith> I'm attaching the latest revision of this patch. Thanks. Keith> + sym = cp_lookup_symbol_namespace (scope, name, Keith> + block, domain); Keith> + if (sym != NULL) Keith> + return sym; Keith> + Keith> + /* A simple lookup failed. Check if the symbol was defined in Keith> + a base class. */ I wonder if this implements the right search rules. Suppose you have something like: namespace N { typedef double value_type; struct Base { typedef int value_type; }; struct Derived : public Base { }; } ptype N::Derived::value_type should print 'int' -- but from the comment and placement of this code I wonder if it would print 'double'. Keith> + sprintf (concatenated_name, "%s::%s", base_name, name); Pierre is trying to replace these with xsnprintf. Tom