From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16294 invoked by alias); 21 Jan 2013 16:13:07 -0000 Received: (qmail 16276 invoked by uid 22791); 21 Jan 2013 16:13:05 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Jan 2013 16:12:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0LGCpow026650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Jan 2013 11:12:51 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0LGCnV4002992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 21 Jan 2013 11:12:50 -0500 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix gdb.fortran/common-block.exp crash in PIE mode References: <20130119224534.GA26330@host2.jankratochvil.net> Date: Mon, 21 Jan 2013 16:13:00 -0000 In-Reply-To: <20130119224534.GA26330@host2.jankratochvil.net> (Jan Kratochvil's message of "Sat, 19 Jan 2013 23:45:34 +0100") Message-ID: <874nia4iri.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00476.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> as it thinks it can update it like SYMBOL_VALUE_ADDRESS Jan> CORE_ADDR address; Jan> due to its LOC_STATIC. Jan> Fix gdb.fortran/common-block.exp crash in PIE mode. Jan> * dwarf2read.c (new_symbol_full) : Use Jan> LOC_COMMON_BLOCK. Jan> * f-valprint.c (info_common_command_for_block): Expect Jan> LOC_COMMON_BLOCK in gdb_assert. Jan> * symtab.h (struct general_symbol_info): Update comment for the Jan> common_block member. Jan> (domain_enum): Extend comment for the COMMON_BLOCK_DOMAIN member. Jan> (enum address_class): New member LOC_COMMON_BLOCK. Looks good to me. Perhaps the various symbol-value accessors like SYMBOL_VALUE_ADDRESS should make assertions about the address class. This is what GCC does in its tree accessors. Like #define SYMBOL_VALUE_COMMON_BLOCK(symbol) \ ((gdb_assert (SYMBOL_CLASS (symbol) == LOC_COMMON_BLOCK)), \ (symbol)->info.value.common_block) Tom