From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22873 invoked by alias); 12 Mar 2013 20:10:52 -0000 Received: (qmail 22857 invoked by uid 22791); 12 Mar 2013 20:10:51 -0000 X-SWARE-Spam-Status: No, hits=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Mar 2013 20:10:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2CKAeKp011639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Mar 2013 16:10:40 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r2CKAcKw018182 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 12 Mar 2013 16:10:39 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH v3 13/15] Test on saving tracepoint defs. References: <1362800844-27940-1-git-send-email-yao@codesourcery.com> <1362800844-27940-14-git-send-email-yao@codesourcery.com> Date: Tue, 12 Mar 2013 20:10:00 -0000 In-Reply-To: <1362800844-27940-14-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Sat, 9 Mar 2013 11:47:22 +0800") Message-ID: <874ngge5vl.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00551.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2013-03-08 Yao Qi Yao> * gdb.trace/actions.exp (check_tracepoint): New. Yao> (top level): Start the tracing and check the actions of Yao> tracepoints. Save trace data to tfile format. Restart GDB Yao> and read trace file in tfile target. Check the actions of Yao> tracepoints again. Yao> * gdb.trace/while-stepping.exp: Likewise. Yao> +gdb_test "break main" Yao> +gdb_run_cmd Yao> +gdb_test "" "Breakpoint .*" I'd prefer some refactoring of gdb_run_cmd or runto instead. gdb_test with an empty argument has always struck me as iffy. Yao> +if ![gdb_target_supports_trace] { Yao> + unsupported "target does not support trace" Yao> + return -1; No semicolon. Yao> +gdb_test "tsave ${testfile}.tf" \ Yao> + "Trace data saved to file '${testfile}.tf'\.\\r" Would you mind using standard_output_file? Yao> +# Restart GDB and read the trace data in tfile target. Yao> +gdb_exit Yao> +gdb_start Yao> +gdb_reinitialize_dir $srcdir/$subdir Yao> +gdb_file_cmd $binfile clean_restart? Yao> +gdb_test "break main" Yao> +gdb_run_cmd Yao> +gdb_test "" "Breakpoint .*" Yao> +if ![gdb_target_supports_trace] { Yao> + unsupported "target does not support trace" Yao> + return -1; Yao> +} Same comments here. Yao> +proc check_tracepoint { data_source } { with_test_prefix "$data_source" { Formatting of with_test_prefix. (I forgot to mention it, but same in the other file.) Yao> +# Restart GDB and read the trace data in tfile target. Yao> +gdb_exit Yao> +gdb_start Yao> +gdb_reinitialize_dir $srcdir/$subdir Yao> +gdb_file_cmd $binfile clean_restart? Yao> +gdb_test "target tfile ${testfile}.tf" ".*" \ Yao> + "change to tfile target" standard_output_file Tom