From c2dee2f4e0c0665fe308e596969d5bb3076fdc09 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Mon, 22 Apr 2013 12:23:19 -0600 Subject: [PATCH 07/33] fix py-evtregistry.c refcount bug The checker found a refcounting bug in py-evtregistry.c. * py-evtregistry.c (create_event_object): Decref eventregistry_object if PyList_New fails. --- gdb/python/py-evtregistry.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/python/py-evtregistry.c b/gdb/python/py-evtregistry.c index c8003af..05c8586 100644 --- a/gdb/python/py-evtregistry.c +++ b/gdb/python/py-evtregistry.c @@ -89,7 +89,10 @@ create_eventregistry_object (void) eventregistry_obj->callbacks = PyList_New (0); if (!eventregistry_obj->callbacks) - return NULL; + { + Py_DECREF (eventregistry_obj); + return NULL; + } return eventregistry_obj; } -- 1.8.1.4