From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20899 invoked by alias); 3 Dec 2013 12:53:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20883 invoked by uid 89); 3 Dec 2013 12:52:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.0 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: aserp1040.oracle.com Received: from Unknown (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Dec 2013 12:52:54 +0000 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rB3CqkLJ022710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Dec 2013 12:52:47 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rB3CqjKE001227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 3 Dec 2013 12:52:45 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rB3CqiCe015152; Tue, 3 Dec 2013 12:52:44 GMT Received: from termi.oracle.com (/10.175.20.72) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Dec 2013 04:52:44 -0800 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] testsuite: sigall.exp: handle SIGLOST/SIGPWR conflict in sparc64 targets References: <877gd4t72x.fsf@oracle.com> <87iov6w3g9.fsf@oracle.com> <201312031207.rB3C7KF1012549@glazunov.sibelius.xs4all.nl> Date: Tue, 03 Dec 2013 12:53:00 -0000 In-Reply-To: <201312031207.rB3C7KF1012549@glazunov.sibelius.xs4all.nl> (Mark Kettenis's message of "Tue, 3 Dec 2013 13:07:20 +0100 (CET)") Message-ID: <874n6qw0uv.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00084.txt.bz2 > + # In SPARC64 systems SIGLOST==SIGPWR and gdb identifies the raised > + # signal as PWR. Change that into "On Linux SPARC64 systems..." With that change, this is fine with me. Ok. Patch amended below and committed. (By mistake I pushed a wrong date in the testsuite/ChangeLog entry and had to fix that with a new commit. Sorry about that!.) 2013-12-03 Jose E. Marchesi * gdb.base/sigall.exp (test_one_sig): gdb identifies SIGLOST as a SIGPWR in sparc64. * gdb.base/sigall.c (main): In some targets SIGLOST and SIGPWR have the same signal number. Handle this situation. diff --git a/gdb/testsuite/gdb.base/sigall.c b/gdb/testsuite/gdb.base/sigall.c index 110029d..68f3ecb 100644 --- a/gdb/testsuite/gdb.base/sigall.c +++ b/gdb/testsuite/gdb.base/sigall.c @@ -1083,7 +1083,7 @@ return 0; int gen_PWR () { -#ifdef SIGPWR +#if defined(SIGPWR) && (!defined (SIGLOST) || SIGPWR != SIGLOST) kill (getpid (), SIGPWR); #else handle_PWR (0); @@ -1662,7 +1662,7 @@ main () #ifdef SIGUSR2 signal (SIGUSR2, handle_USR2); #endif -#ifdef SIGPWR +#if defined(SIGPWR) && (!defined (SIGLOST) || SIGPWR != SIGLOST) signal (SIGPWR, handle_PWR); #endif #if defined (SIGPOLL) && (!defined (SIGIO) || SIGPOLL != SIGIO) diff --git a/gdb/testsuite/gdb.base/sigall.exp b/gdb/testsuite/gdb.base/sigall.exp index b1b8597..d531479 100644 --- a/gdb/testsuite/gdb.base/sigall.exp +++ b/gdb/testsuite/gdb.base/sigall.exp @@ -39,12 +39,20 @@ proc test_one_sig {nextsig} { set need_another_continue 1 set missed_handler 0 if $this_sig_supported then { + set esig $thissig + if { $thissig == "IO" } { setup_xfail "i*86-pc-linuxoldld-gnu" "i*86-pc-linuxaout-gnu" } + # On Linux SPARC64 systems SIGLOST==SIGPWR and gdb identifies + # the raised signal as PWR. + if { $thissig == "LOST" && [ istarget "sparc64-*-linux*" ] } then { + set esig "PWR" + } + gdb_test "continue" \ - "Continuing.*Program received signal SIG$thissig.*" \ - "get signal $thissig" + "Continuing.*Program received signal SIG$esig.*" \ + "get signal $esig" } if [ istarget "alpha-dec-osf3*" ] then { # OSF/1-3.x is unable to continue with a job control stop signal.