From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5283 invoked by alias); 1 Dec 2014 20:34:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5271 invoked by uid 89); 1 Dec 2014 20:34:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 01 Dec 2014 20:34:39 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB1KYch3017858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 1 Dec 2014 15:34:38 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB1KYbUM005925 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 1 Dec 2014 15:34:38 -0500 From: Sergio Durigan Junior To: Cleber Rosa Cc: gdb-patches@sourceware.org, cleber@redhat.com Subject: Re: [PATCH 1/2] remote-utils.c: remove unused gdb_stdlog References: <1417449499-23681-1-git-send-email-crosa@redhat.com> X-URL: http://blog.sergiodj.net Date: Mon, 01 Dec 2014 20:34:00 -0000 In-Reply-To: <1417449499-23681-1-git-send-email-crosa@redhat.com> (Cleber Rosa's message of "Mon, 1 Dec 2014 12:58:18 -0300") Message-ID: <874mtfyuqq.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00025.txt.bz2 On Monday, December 01 2014, Cleber Rosa wrote: > It looks like this came from an attempt to mimmic gdb/main.c, which > has gdb_stdlog, gdb_stderr, gdb_stdout, etc. But in reality, it's > not being used on gdbserver. Heya :-). Thanks for sending the patch upstream. As we have already discussed on private, this looks almost obvious to me, but let's wait for some maintainer to approve. Meanwhile... > Signed-off-by: Cleber Rosa We don't use Signed-off-by here, but it shouldn't do any harm to keep it in the patch. > --- > gdb/gdbserver/ChangeLog | 4 ++++ > gdb/gdbserver/remote-utils.c | 1 - > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog > index e378a5f..0e110e7 100644 > --- a/gdb/gdbserver/ChangeLog > +++ b/gdb/gdbserver/ChangeLog > @@ -1,3 +1,7 @@ > +2014-12-01 Cleber Rosa > + > + * remote-utils.c: Remove unused variable. Every entry in the ChangeLog should be indented using TABs, and not spaces. You could also specify *which* unused variable you are removing. Thus: * remote-utils.c: Remove unused variable "gdb_stdlog". > + > 2014-11-28 Yao Qi > > * configure.ac(AC_CHECK_FUNCS): Remove readlink. > diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c > index 373fc15..442e94e 100644 > --- a/gdb/gdbserver/remote-utils.c > +++ b/gdb/gdbserver/remote-utils.c > @@ -100,7 +100,6 @@ struct sym_cache > }; > > int remote_debug = 0; > -struct ui_file *gdb_stdlog; > > static int remote_is_stdio = 0; > > -- > 1.9.3 Thanks, -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/