Re: [PATCH v4 0/4] catch syscall group

Pedro Alves
2015-05-13T10:47:14Z

On 05/11/2015 01:27 AM, Gabriel Krisman Bertazi wrote:
> Thank you both for your review.
>
> This version has the following improvements:
>
> * Apply fixes suggested by Sergio in the testsuite.
> * Use xsltproc to generate the xml files.
>
> Regarding the last change, it allowed me to identify inconsistencies in
> groups for some architectures.

It was a useful exercise then. ;-) Many thanks for following through
with this.

> The current design makes sure these
> inconsistencies are fixed by centralizing the group information in a
> single file.
>
> Also, this patch series *does not* include the generated files because
> they are too big and can get in the way of code review. Reviewers must
> generate those files by hand by entering the gdb/syscalls directory and
> running the makefile there. Build will fail if reviewer don't do this!
> Once we get this approved, I'll make sure to include the generated files
> in the commit before pushing. Hopefully this will make code review
> easier.

Do you have a public branch somewhere with that already done?
That'd make it easier for people to check the end result. You could push
it to sourceware.org git nowadays, under "users/$yourname/$branch". That
would be the easiest.

> Also, I generated this format-patch with --find-renames. If it gets in
> the way of git am/git apply, please let me know and I'll resend it.
>
> As usual, I'm not resending the documentation patch again because it was
> already approved by Eli.

Thanks,
Pedro Alves