Re: [PATCH v4 0/4] catch syscall group

Doug Evans
2015-05-12T22:44:19Z

On Tue, May 12, 2015 at 3:02 PM, Sergio Durigan Junior
<sergiodj@redhat.com> wrote:
> On Tuesday, May 12 2015, Doug Evans wrote:
>
>> > Also, this patch series *does not* include the generated files because
>> > they are too big and can get in the way of code review. Reviewers must
>> > generate those files by hand by entering the gdb/syscalls directory and
>> > running the makefile there. Build will fail if reviewer don't do this!
>> > Once we get this approved, I'll make sure to include the generated files
>> > in the commit before pushing. Hopefully this will make code review
>> > easier.
>>
>> This sounds like something we should key off of --enable-maintainer-mode.
>> [we *could* use a different option if people are wedded to
>> --enable-maintainer-mode affecting only autogen files, but
>> that seems like overkill]
>
> What exactly are you refering to? Generating the XML files using
> xsltproc when compiling GDB? I will assume this in the rest of the
> message, but if that's not what you meant, then please disconsider.

Ah. I figured people know what --enable-maintainer-mode is. :-)

--enable-maintainer-mode is a configure time option that turns
on some makefile dependency checking that is normally off.
It is used, for example, to automagically regenerate configure
when configure.ac changes, and only when make's
standard processing says they need regenerating: i.e.,
when the timestamp of the generated file is older than a timestamp
of one of its dependencies.

What happens if the user doesn't supply --enable-maintainer-mode
when configuring? [which is the norm]
Then the dependencies are turned off and no automagic regeneration
is done (which is what one would want for a default).

> I don't necessarily oppose hooking the XML generation into the
> --enable-maintainer-mode option, but I'm having the impression that we
> are bloating this feature more and more, without much gain. Unless I'm
> really blind to some benefit, in which case I apologize in advance.

What I'm asking for is trivial to do (there's already boilerplate
to cut-n-paste-n-tweak form), *and* it is s.o.p.
[If people want a different configure option than --enable-maintainer-mode
than it'll involve a bit more work, but it's still all s.o.p.]

I really don't think I'm asking for anything unusual or excessive.