From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14850 invoked by alias); 22 Dec 2016 14:50:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14827 invoked by uid 89); 22 Dec 2016 14:50:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:789 X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Thu, 22 Dec 2016 14:49:55 +0000 Received: (qmail 24352 invoked by uid 0); 22 Dec 2016 14:49:53 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy6.mail.unifiedlayer.com with SMTP; 22 Dec 2016 14:49:53 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id P2po1u00X2f2jeq012prWB; Thu, 22 Dec 2016 07:49:51 -0700 X-Authority-Analysis: v=2.1 cv=KYpB72oD c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=mDV3o1hIAAAA:8 a=G1uICXq7AcMQGn1AAJgA:9 a=e_O65bzb51kRm2y5VmPK:22 a=_FVE-zBwftR9WsbkzFJk:22 Received: from 75-171-175-27.hlrn.qwest.net ([75.171.175.27]:43518 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cK4go-0003PE-2z; Thu, 22 Dec 2016 07:49:50 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-8-git-send-email-tom@tromey.com> <878ts2yi5m.fsf@tromey.com> <87inqletsw.fsf@tromey.com> <7f11b7bb-bebb-1cd3-1e92-266638272443@redhat.com> <87vaueuqoh.fsf@tromey.com> <819d6d1b-1afb-277c-3bf4-e8cc5884ac43@redhat.com> Date: Thu, 22 Dec 2016 14:50:00 -0000 In-Reply-To: <819d6d1b-1afb-277c-3bf4-e8cc5884ac43@redhat.com> (Pedro Alves's message of "Tue, 20 Dec 2016 23:56:00 +0000") Message-ID: <874m1w6mt0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cK4go-0003PE-2z X-Source-Sender: 75-171-175-27.hlrn.qwest.net (bapiya) [75.171.175.27]:43518 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00372.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Tom> Probably this should use __attribute__((warn_unused_result)), but that Tom> isn't wrapped in ansidecl.h (yet) and I don't know offhand what version Tom> test to use for it. Do you? Pedro> Good idea. Looks like it's GCC 3.4. This turns out not to work :( FWIW in addition to the ATTRIBUTE_WARN_UNUSED_RESULT patch, I also had to patch gdb's configure script to add -Wunused-result, as -Wunused turns this off. The g++ bug is known: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38172 It looks like the accepted fix upstream to use the C++17 [[nodiscard]] attribute; not sure if we can use that somehow. Meanwhile I'm going to drop this part of my patch. Tom