From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109639 invoked by alias); 23 Sep 2017 02:10:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109216 invoked by uid 89); 23 Sep 2017 02:10:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=struggling X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 23 Sep 2017 02:09:59 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 85B9CC057F93; Sat, 23 Sep 2017 02:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 85B9CC057F93 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5CF025E1CB; Sat, 23 Sep 2017 02:09:57 +0000 (UTC) From: Sergio Durigan Junior To: "Maciej W. Rozycki" Cc: , , Pedro Alves , Djordje Todorovic Subject: Re: [PATCH 0/4] Fix issues with Linux core PRPSINFO note definitions References: Date: Sat, 23 Sep 2017 02:10:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Sat, 23 Sep 2017 01:02:20 +0100") Message-ID: <874lruxj0r.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00714.txt.bz2 On Friday, September 22 2017, Maciej W. Rozycki wrote: > Hi, > > This patch series addresses problems with Linux core PRPSINFO note > definitions, discovered in the course of Djordje's MIPS PID extraction > patch review. See individual patch descriptions for details. > > These changes have passed binutils regression testing against my usual > targets (for the BFD part) and also native GDB regression testing with the > `x86_64-linux-gnu' target and the `mips-linux-gnu' n64 target (for the GDB > part, and the `gcore' command in particular). > > OK to apply? Hey Maciej, Aside from a small nit on patch #3, I really like the direction you chose on this patch. I am not a binutils maintainer and not a GDB global maintainer, so I cannot approve it, but it does look good to me and makes the existing code more logical and simpler to follow. I also like the fact that you removed the responsibility that GDB had to decide which prpsinfo structure it would use. That's something I remember struggling with when I was hacking the initial patch, and I'm glad this patch solves it. So, LGTM. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/