Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Mike Gulick <mike.gulick@mathworks.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/Makefile.in: fix 'make tags' failure
Date: Mon, 30 Oct 2017 23:02:00 -0000	[thread overview]
Message-ID: <874lqg9r3t.fsf@redhat.com> (raw)
In-Reply-To: <68f1f2bf-a5a9-d1e5-6f5a-ea9d5db3b887@mathworks.com> (Mike	Gulick's message of "Mon, 30 Oct 2017 18:19:15 -0400")

On Monday, October 30 2017, Mike Gulick wrote:

> 'make tags' has been broken in master for a couple of weeks.  Hopefully this
> is small enough to not require copyright attribution.  Otherwise someone can
> be "inspired" by this change to fix it themselves.

Thanks for the patch, Mike.  Could you please write a proper ChangeLog
entry and a more descriptive commit message?  When you do that I can
push this in for you under the obvious rule.

Thanks,

> ---
> From c3936e0e1bf4fab486965496d7ad3966b1846eb8 Mon Sep 17 00:00:00 2001
> From: Mike Gulick <mgulick@mathworks.com>
> Date: Thu, 19 Oct 2017 16:51:33 -0400
> Subject: [PATCH] gdb/Makefile.in: fix 'make tags' failure
>
> Remove reference to gdb.h, which was removed in commit
> 65630365f7d073430e62b4fe65f34dcdc0a4b05e.
> ---
>  gdb/Makefile.in | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 6cb0970..1a68746 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1346,7 +1346,6 @@ HFILES_NO_SRCDIR = \
>    frv-tdep.h \
>    ft32-tdep.h \
>    gcore.h \
> -  gdb.h \
>    gdb_bfd.h \
>    gdb_curses.h \
>    gdb-dlfcn.h \
> -- 
> 2.1.4

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


  reply	other threads:[~2017-10-30 23:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-30 22:19 Mike Gulick
2017-10-30 23:02 ` Sergio Durigan Junior [this message]
2017-10-31  0:12   ` Mike Gulick
2017-10-31  1:33     ` Sergio Durigan Junior
2017-10-31  1:41       ` Mike Gulick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lqg9r3t.fsf@redhat.com \
    --to=sergiodj@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mike.gulick@mathworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox