From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48227 invoked by alias); 7 Feb 2018 15:29:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45147 invoked by uid 89); 7 Feb 2018 15:29:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:483, HX-HELO:sk:gateway X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.48.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 15:29:55 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway23.websitewelcome.com (Postfix) with ESMTP id EE6F4D266 for ; Wed, 7 Feb 2018 09:29:53 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id jRfVeGNLIBUMKjRfVeJVD1; Wed, 07 Feb 2018 09:29:53 -0600 Received: from 174-29-33-254.hlrn.qwest.net ([174.29.33.254]:52216 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ejRfV-001PxQ-Ku; Wed, 07 Feb 2018 09:29:53 -0600 From: Tom Tromey To: Yao Qi Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH] New class allocate_on_obstack References: <1517996444-8605-1-git-send-email-yao.qi@linaro.org> Date: Wed, 07 Feb 2018 15:29:00 -0000 In-Reply-To: <1517996444-8605-1-git-send-email-yao.qi@linaro.org> (Yao Qi's message of "Wed, 7 Feb 2018 09:40:44 +0000") Message-ID: <874lmsyg0f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1ejRfV-001PxQ-Ku X-Source-Sender: 174-29-33-254.hlrn.qwest.net (pokyo) [174.29.33.254]:52216 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-02/txt/msg00121.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> This patch adds a new class allocate_on_obstack, and let dwarf2_per_objfile Yao> inherit it, so that dwarf2_per_objfile is automatically allocated on Yao> obstack, and "delete dwarf2_per_objfile" doesn't de-allocate any space. I still think it should be restricted to types with a trivial destructor. Otherwise, someday, the lack of actual destruction is going to cause a bug. Tom