From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119313 invoked by alias); 9 Mar 2018 04:58:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119293 invoked by uid 89); 9 Mar 2018 04:58:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Mar 2018 04:58:57 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id B3FD6AD289A for ; Thu, 8 Mar 2018 22:58:55 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uA7Lezh8tcGlpuA7LesBib; Thu, 08 Mar 2018 22:58:55 -0600 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:56230 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1euA7L-002ROE-F3; Thu, 08 Mar 2018 22:58:55 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Change enable_thread_stack_temporaries to an RAII class References: <20180308053543.18516-1-tom@tromey.com> <8926b4ac-73f3-a7c8-3e7d-cebe3ec4f311@simark.ca> Date: Fri, 09 Mar 2018 04:58:00 -0000 In-Reply-To: <8926b4ac-73f3-a7c8-3e7d-cebe3ec4f311@simark.ca> (Simon Marchi's message of "Thu, 8 Mar 2018 22:57:15 -0500") Message-ID: <874llpone9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1euA7L-002ROE-F3 X-Source-Sender: 174-29-60-18.hlrn.qwest.net (bapiya) [174.29.60.18]:56230 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-03/txt/msg00188.txt.bz2 >> + bool stack_temporaries_enabled; Simon> I think we can just removed this field, it seems to be unused. Thanks for noticing this, I've removed it. Simon> The "if (!tp->stack_temporaries.empty ())" here is now unnecessary. I made this change as well. Tom