From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14746 invoked by alias); 13 Mar 2018 23:40:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14727 invoked by uid 89); 13 Mar 2018 23:40:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.216) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Mar 2018 23:40:17 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id ACF28EAEC for ; Tue, 13 Mar 2018 18:40:15 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id vtWheLyJbntAovtWhe1q25; Tue, 13 Mar 2018 18:40:15 -0500 Received: from 174-29-60-18.hlrn.qwest.net ([174.29.60.18]:46702 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1evtWh-0004QE-F6; Tue, 13 Mar 2018 18:40:15 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Remove two cleanups using std::string References: <20180312223829.7108-1-tom@tromey.com> Date: Tue, 13 Mar 2018 23:40:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 12 Mar 2018 22:37:32 -0400") Message-ID: <874lljtuhu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1evtWh-0004QE-F6 X-Source-Sender: 174-29-60-18.hlrn.qwest.net (bapiya) [174.29.60.18]:46702 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-03/txt/msg00274.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> LGTM. I would be more confident if that non-trivial escaping code was Simon> unit-tested, but I tried it by hand and it seems to do what it's supposed Simon> to do. Yeah. I looked at this briefly but it seemed like a lot of work for not a huge benefit. Maybe if some other code was doing the same thing, it would make sense to pull this logic out into its own function. Tom