From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114788 invoked by alias); 5 Jun 2018 22:56:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114776 invoked by uid 89); 5 Jun 2018 22:56:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=simonmarchipolymtlca, simon.marchi@polymtl.ca, H*f:sk:15d0da9, psymbol X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.193.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Jun 2018 22:56:36 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 012FE400D0A0D for ; Tue, 5 Jun 2018 17:56:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id QKsUfHLQg79N3QKsUflYBQ; Tue, 05 Jun 2018 17:56:34 -0500 X-Authority-Reason: nr=8 Received: from 75-166-37-59.hlrn.qwest.net ([75.166.37.59]:39636 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fQKsU-000fVi-Nq; Tue, 05 Jun 2018 17:56:34 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Keith Seitz , gdb-patches@sourceware.org Subject: Re: [RFA 2/6] Change representation of psymbol to flush out accessors References: <20180503223621.22544-1-tom@tromey.com> <20180503223621.22544-3-tom@tromey.com> <15d0da9f-93fa-5d23-ce4e-43d5befe48e7@redhat.com> <871sdm5smj.fsf@tromey.com> <7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca> Date: Tue, 05 Jun 2018 22:56:00 -0000 In-Reply-To: <7fa5ee6be895cd708b6cf646b1dbbff4@polymtl.ca> (Simon Marchi's message of "Tue, 05 Jun 2018 15:48:17 -0400") Message-ID: <874lig4zby.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fQKsU-000fVi-Nq X-Source-Sender: 75-166-37-59.hlrn.qwest.net (bapiya) [75.166.37.59]:39636 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00131.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I wanted for a while to convert all these macros to static inline Simon> functions, it just hasn't been high on the todo list. Since you're Simon> adding new code, would you mind making them static inline functions Simon> instead of macros (if you agree with the idea, of course)? How about just getting rid of them entirely and referring to the members directly? IMO the macros don't add any value, and I suppose functions wouldn't really, either, with the exception of one for computing the address. This could be the only method. Tom