Re: [PATCH 5/9] Change decode_compound_collector to use std::vector

Tom Tromey
2018-08-28T17:46:58Z

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

>> Won't this end up copying m_symbols?

Keith> Yup. Forgot to move the return value (which would also clear/reset m_symbols
Keith> as expected today).

Keith> This patch has one additional change over v1: the final qsort is replaced with
Keith> std::sort and the temporary std_compare_symbol function replaces the
Keith> qsort-oriented compare_symbol function (mentioned in a previous patch email).

Thanks, this is ok.

Tom