Re: [PATCH 9/9] C++ compile support

Keith Seitz
2018-08-20T17:02:36Z

On 08/17/2018 11:57 AM, Eli Zaretskii wrote:
>> I'm not sure how to answer this. That seems like enumerating all the dependencies
>> of every dependency GDB has (bfd, libiberty, bison, etc). The feature (like the
>> C compile feature already included) requires the compiler plug-in. Whatever that
>> plug-in supports is what GDB supports.
>
> It is okay to say that this is supported only on platforms where
> libcc1.so and the 'compile' command are available. My problem was
> with not qualifying this at all.

Gotcha. I've "copied" the announcement text from the original (C) compile
submission talking about compiler requirement:

This feature requires GCC 7.1 or higher built with libcp1.so
(the C++ plug-in).

>> Would you like me to include something like: "Currently tested on x86_64
>> GNU/Linux."
>
> Using "currently" is generally not advisable, as the meaning of that
> word changes with time.

Indeed! I've removed this text in favor of the above requirement statement.

>> Would you like me to repost this patch?
>
> That won't be needed, thanks.

Thank you for your comments/suggestions!

Keith