Re: [PATCH 2/9] Change `function_symbols' to std::vector

Tom Tromey
2018-08-28T17:43:51Z

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> I know you approved this, but based on feedback on the minimal_symbols patch
Keith> (#4 in this series), I thought I would also switch to sorting function_symbols
Keith> with std::sort instead of qsort.

Keith> This does involve introducing a new "std_compare_symbols" function since the
Keith> one remaining qsort cannot be eliminated until later. [By the end of the
Keith> series, though, we will be back to one Compare function again.]

Keith> This is the only change in this revision.

Thanks, this is ok.
It's always fine to push back on a review, like in this case if it was
simpler to tack on a patch to convert to std::sort, rather than fixing
it mid-stream, that would have been fine.

Tom