From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31568 invoked by alias); 28 Aug 2018 17:30:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31282 invoked by uid 89); 28 Aug 2018 17:30:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=transfer X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 17:30:27 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id A0DFC26E01 for ; Tue, 28 Aug 2018 12:30:26 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uhowfHaQikBj6uhowfVXOu; Tue, 28 Aug 2018 12:30:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YAiartjJOeZUvStWft3h0+n56p9LQXT2u/ruOUoWaEk=; b=mmHRvhXGSsYMRphBNJmCHWVPUY F/xZBcChHn+E136ibq27wD+HRvd2s1V2wyvn1OBlFIyrj5drqwpX/z71ZsucyunpqrsxHNi99HtiO tCjntJp6hDIlVyKalruTHhQ+3; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:47844 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fuhow-001uEn-EN; Tue, 28 Aug 2018 12:30:26 -0500 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Change `file_symtabs' to std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-2-keiths@redhat.com> <877ekxufho.fsf@tromey.com> Date: Tue, 28 Aug 2018 17:30:00 -0000 In-Reply-To: (Keith Seitz's message of "Fri, 17 Aug 2018 10:56:09 -0700") Message-ID: <874lfe761a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00697.txt.bz2 >>>>> "Keith" == Keith Seitz writes: >> IIUC, this transfers ownership of the symtab_vector_up from the >> collector to the caller. So how about having this, >> symtabs_from_filename, and symtab_collector::release_symbols return a >> symtab_vector_up instead? That would make the ownership transfer part >> of the API. Keith> Indeed. How about the below? [This is the only change in the following Keith> patch.] Thanks! This is ok. Tom