From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98144 invoked by alias); 9 Sep 2018 02:55:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98094 invoked by uid 89); 9 Sep 2018 02:55:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:757 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 09 Sep 2018 02:55:46 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 77372CCA for ; Sat, 8 Sep 2018 21:55:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ypt3fjWXASjJAypt3fMU8T; Sat, 08 Sep 2018 21:55:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oEmsgOeZ3eFfQ2N8845RKoafje30hKPUyosxg/tcKCg=; b=sdRm+jQG2JLTkFIsiFhQSOA6TL jX3F3bbiogkEzkS64iOJiNvPGUCvbQWMAvnxQl1F39VcqrgowQcqbGdMOO43EU807pvYnEtm577GV LXcBHU79kzFryXjFPtCX0K07U; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:42960 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fypt3-003aIm-5h; Sat, 08 Sep 2018 21:55:45 -0500 From: Tom Tromey To: Simon Marchi Cc: Subject: Re: [PATCH] python: Make two functions return gdbpy_ref<> References: <1536448885-6222-1-git-send-email-simon.marchi@ericsson.com> Date: Sun, 09 Sep 2018 02:55:00 -0000 In-Reply-To: <1536448885-6222-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Sun, 9 Sep 2018 00:21:25 +0100") Message-ID: <874lez5qhb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00220.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> I noticed that we release a gdbpy_ref in pretty_print_one_value only to Simon> create it again later. This patch fills the gap by returning a Simon> gdbpy_ref all the way. Simon> gdb/ChangeLog: Simon> * python/py-prettyprint.c (pretty_print_one_value): Return Simon> gdbpy_ref<>. Simon> (print_string_repr): Adjust. Simon> (apply_varobj_pretty_printer): Return gdbpy_ref<>. Simon> * python/python-internal.h (apply_varobj_pretty_printer): Return Simon> gdbpy_ref<>. Simon> * varobj.c (varobj_value_get_print_value): Adjust. Thanks, this seems like a good improvement to me. I'm sure there are more of these lurking. Tom