From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22832 invoked by alias); 12 Sep 2018 17:59:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22793 invoked by uid 89); 12 Sep 2018 17:59:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,TRACKER_ID autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Sep 2018 17:59:08 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57C8A40216F6; Wed, 12 Sep 2018 17:59:07 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DC4535446; Wed, 12 Sep 2018 17:59:07 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Rich Felker , Romain Naour , Thomas Petazzoni , Romain Naour Subject: Re: [PATCH] Move 'is_regular_file' from common-utils.c to filestuff.c References: <20180912173113.2007-1-sergiodj@redhat.com> <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> Date: Wed, 12 Sep 2018 17:59:00 -0000 In-Reply-To: <6ee45c62-9bb6-c41a-b76e-0a9bf9c2c281@redhat.com> (Pedro Alves's message of "Wed, 12 Sep 2018 18:41:41 +0100") Message-ID: <874leulhqt.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00369.txt.bz2 On Wednesday, September 12 2018, Pedro Alves wrote: > On 09/12/2018 06:31 PM, Sergio Durigan Junior wrote: > >> The most simple fix for this problem is to move 'is_regular_file' to >> 'filestuff.c', which is not used by IPA. This ends up making the >> files more logically organized as well, since 'is_regular_file' is a >> file operation. >> >> No regressions found. >> >> gdb/ChangeLog: >> 2018-09-12 Sergio Durigan Junior >> >> * common/common-utils.c: Don't include ''. >> (is_regular_file): Move to... >> * common/filestuff.c (is_regular_file): ... here. >> * common/common-utils.h (is_regular_file): Move to... >> * common/filestuff.h (is_regular_file): ... here. > > OK. Thanks, pushed. 3c025cfe5efc44eb4dfb03b53dca28e75096dd1e -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/