From: Tom Tromey <tom@tromey.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
<qiyao@sourceware.org>
Subject: Re: [patch] provide type_align gdbarch function for nios2
Date: Sat, 15 Sep 2018 02:57:00 -0000 [thread overview]
Message-ID: <874lersc18.fsf@tromey.com> (raw)
In-Reply-To: <7428fb6b-bd85-f852-41a4-683e4bea16ee@codesourcery.com> (Sandra Loosemore's message of "Fri, 14 Sep 2018 19:47:19 -0600")
>>>>> "Sandra" == Sandra Loosemore <sandra@codesourcery.com> writes:
Sandra> The attached patch fixes almost 400 failures in gdb.base/align.exp and
Sandra> related tests due to a missing definition for the type_align hook for
Sandra> nios2. I swiped the definition of the hook from the arc backend which
Sandra> has similar conventions: the alignment of byte/halfword types matches
Sandra> their size, but all types 4 bytes or larger are aligned on a 4-byte
Sandra> boundary.
Sandra> OK to commit?
Thank you for the patch. This is ok.
Tom
prev parent reply other threads:[~2018-09-15 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 1:47 Sandra Loosemore
2018-09-15 2:57 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lersc18.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyao@sourceware.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox