From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20526 invoked by alias); 17 Sep 2018 06:32:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20412 invoked by uid 89); 17 Sep 2018 06:31:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1019, HTo:D*ericsson.com X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (50.116.124.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 06:31:48 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 33E58401563BA for ; Mon, 17 Sep 2018 00:37:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1n45g3dmdSjJA1n4Kgf3K1; Mon, 17 Sep 2018 01:31:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RrbeSBE4Jh4v21/tJp5TiJTEaiK5YOWj/UXv7RQIVrY=; b=VYtuOxOm4mzaXAEZ38hiOJewBz 1q5MKw1lBOybJdukCRHvkV2XT2ldzwgcSddW8/nCPqKEoBD8sHH6PJT06sP6g8VQyx+JRXMMfCg8N oVkKp8USKeGylPEiARZjWPv7W; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:49288 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1n44-003NHO-Qf; Mon, 17 Sep 2018 01:31:20 -0500 From: Tom Tromey To: Simon Marchi Cc: , Keith Seitz Subject: Re: [PATCH] compile: Remove non-const reference parameters References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> Date: Mon, 17 Sep 2018 06:32:00 -0000 In-Reply-To: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Thu, 30 Aug 2018 12:47:15 -0400") Message-ID: <874leoocso.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00560.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> As mentioned here: Simon> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead Simon> we prefer to avoid non-const references. This patch changes the Simon> non-const references I could find in the compile/ directory, either by Simon> making them const or changing them to pointers. Simon> I'd say all the changes are pretty obvious, except the one in Simon> compile_cplus_instance::enter_scope which might require more attention. I think this particular change introduced a regression. runtest gdb.compile/*.exp causes gdb to crash for me several times on x86-64 Fedora 28. The code does this: /* Save the new scope. */ m_scopes.push_back (std::move (new_scope)); ... but then later code in the function continues to use new_scope, like: std::for_each (new_scope.begin (), new_scope.end () - 1, Tom