From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48369 invoked by alias); 9 Oct 2018 19:42:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48360 invoked by uid 89); 9 Oct 2018 19:42:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Phil, our X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.147.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 19:42:08 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway30.websitewelcome.com (Postfix) with ESMTP id D8DF71D0FF for ; Tue, 9 Oct 2018 14:42:06 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9xtOgzH9baSey9xtOgLQR5; Tue, 09 Oct 2018 14:42:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dkjnFFi8ycOAUrAsKtDQkF0G6sizunB4KD1rffuX4mg=; b=x07PXzeynmCha6rwV9IOzrxp4y V8Lx7ti2YNPS4JeLRZNRj0cKlobHuMESiJGnwM/5Oj19bcJUUhxlxlZVei0c5JjlX2v3ZNOb+/yfa 1F8IaynJHrUwWab+OYblPgWyf; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:35020 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g9xtO-001u1c-KL; Tue, 09 Oct 2018 14:42:06 -0500 From: Tom Tromey To: Phil Muldoon Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [RFC] Release the GIL while running a gdb command or expression References: <20180915040732.6718-1-tom@tromey.com> <807f284a-e227-37ed-c197-170a7f2abe40@redhat.com> Date: Tue, 09 Oct 2018 19:42:00 -0000 In-Reply-To: <807f284a-e227-37ed-c197-170a7f2abe40@redhat.com> (Phil Muldoon's message of "Tue, 9 Oct 2018 10:51:11 +0100") Message-ID: <874ldugb5e.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00239.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> We've had a similar patch in the Fedora RPM for a while. It's been on Phil> my list to upstream for a bit. Initially I was a bit reluctant Phil> because I hadn't audited all the Python reentry points in GDB to make Phil> sure we reacquired the GIL before interacting with Python. I realize Phil> now this was not a real concern (reviews would catch this and if one Phil> did slip by it would be fixed as a bug.) Yes, I think it would result in a crash. Phil> The only real difference in the patch approach was to make the GIL Phil> release an option over a default. I don't think this is necessary, mostly because I can't think of when it would be desirable not to release the GIL; but also because when writing Python one doesn't normally have to worry about the GIL -- it's not really a Python-visible feature, nor should it be, since implementations like PyPY don't have it. Phil> As for a test, we also have a test included. It does not appear to be Phil> racy for our purposes. I also include it for consideration. This Phil> snippet is just for initial consideration and will make any changes Phil> needed to include it in the patch. I can try it. If it works, whose name should I put on the ChangeLog? Tom