From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30372 invoked by alias); 12 Jan 2019 22:58:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30358 invoked by uid 89); 12 Jan 2019 22:58:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1211 X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jan 2019 22:58:13 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 147C210353 for ; Sat, 12 Jan 2019 16:58:11 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iSEFgrwuuiQeriSEFgsht0; Sat, 12 Jan 2019 16:58:11 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jfayXYWkOQmYoPbctWk/AOCuzx2s60EhqTnGR7tCJ+Q=; b=MdDAH+ienu/EonDzBi0iRdmoVI 92c3VL0lmSE2T9qGPUW4vKE6lIRxtcxISouF2pETM8Jf+Aat4L/oiLDPl6OLDeIo9fOFcob46oNQg iyIadKBmPyXGXH4gZsw1DmOg1; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:39696 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1giSEE-003JPF-PL; Sat, 12 Jan 2019 16:58:10 -0600 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 3/3] Make symtab.c better styled. References: <20190110220113.26169-1-philippe.waroquiers@skynet.be> <20190110220113.26169-4-philippe.waroquiers@skynet.be> <8736pxx2ow.fsf@tromey.com> <1547311697.5979.7.camel@skynet.be> Date: Sat, 12 Jan 2019 22:58:00 -0000 In-Reply-To: <1547311697.5979.7.camel@skynet.be> (Philippe Waroquiers's message of "Sat, 12 Jan 2019 17:48:17 +0100") Message-ID: <874ladv5z2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-01/txt/msg00302.txt.bz2 >>>>> "Philippe" =3D=3D Philippe Waroquiers = writes: Philippe> To differentiate between data and text, would the condition Philippe> in=C2=A0expand_symtab_containing_pc be ok ? Philippe> i.e. variable styling would be used for data, i.e. : Philippe> (MSYMBOL_TYPE (msymbol.minsym) =3D=3D mst_data Philippe> =C2=A0=C2=A0|| MSYMBOL_TYPE (msymbol.minsym) =3D=3D mst_bss Philippe> =C2=A0=C2=A0|| MSYMBOL_TYPE (msymbol.minsym) =3D=3D mst_abs Philippe> =C2=A0=C2=A0|| MSYMBOL_TYPE (msymbol.minsym) =3D=3D mst_file_data Philippe> =C2=A0=C2=A0|| MSYMBOL_TYPE (msymbol.minsym) =3D=3D mst_file_bss= )) Philippe> and function name styling would be used for the rest i.e.: Philippe> =C2=A0 mst_text, /* Generally executable instructions */ Philippe> =C2=A0 mst_text_gnu_ifunc,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0/* Executable code returning address Philippe> =C2=A0=C2=A0=C2=A0of executable code */ Philippe> =C2=A0 mst_data_gnu_ifunc, /* Executable code returning address Philippe> =C2=A0=C2=A0=C2=A0of executable code */ Philippe> =C2=A0 mst_slot_got_plt, /* GOT entries for .plt sections */ Philippe> =C2=A0 mst_solib_trampoline, /* Shared library trampoline code */ Philippe> =C2=A0 mst_file_text, /* Static version of mst_text */ Yes, I think that's reasonable. Tom