From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121515 invoked by alias); 26 Feb 2019 22:02:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121473 invoked by uid 89); 26 Feb 2019 22:02:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Feb 2019 22:02:29 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 6DABD5C4565 for ; Tue, 26 Feb 2019 16:02:28 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id yko0gqwlFdnCeyko0gnONs; Tue, 26 Feb 2019 16:02:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Nv8oxuUmwsi3K4bsItBwnz2MdIynzmI5oyiRR3/JCEI=; b=qcGLGCuhAuNhmCyPDejuG1X98J zYrLyTrQoOACuNkIVueajN7Z01j9teK4m5av2lK9Cqbn/t6Hlu1pyMPfGJz+Y0CCur9J1J2rYCGcC 15j0xy7I57InY6cSfxk1ylhM2; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:58734 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gyko0-003bqY-5T; Tue, 26 Feb 2019 16:02:28 -0600 From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC] Fix BFD leak in solib-darwin.c References: <20190222163645.9349-1-tromey@adacore.com> <184aefb1-38fc-cc39-0f3a-4bd350c47e11@FreeBSD.org> <8736oae21e.fsf@tromey.com> Date: Tue, 26 Feb 2019 22:02:00 -0000 In-Reply-To: (John Baldwin's message of "Tue, 26 Feb 2019 12:36:49 -0800") Message-ID: <874l8qcioc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-02/txt/msg00461.txt.bz2 >>>>> "John" == John Baldwin writes: John> I think the warning would be useful if it doesn't trigger a lot of false John> positives. I feel like it wouldn't today. When I was grep'ing for John> 'release ()' I only focused on the calls that weren't assigning a value John> to a result and I feel like there weren't many of those (and some were John> assigning, just not obvious in the one line of grep context). Yeah. I went ahead and did this... I had to fix up a few spots, nothing too terrible. It caught one bug, in varobj.c: if (pretty_printer == Py_None) pretty_printer.release (); install_visualizer (var->dynamic, NULL, pretty_printer.release ()); I think that first release should be .reset(nullptr) instead. I'll send it through the buildbot and see what happens there. Tom