From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68236 invoked by alias); 4 Aug 2019 21:21:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68228 invoked by uid 89); 4 Aug 2019 21:21:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SEMBLACK,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=Marchi, marchi X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.51.6) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 04 Aug 2019 21:21:28 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 53CCA400C50ED for ; Sun, 4 Aug 2019 15:17:40 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id uNwVhKe8Z4FKpuNwVhTHzc; Sun, 04 Aug 2019 16:21:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pzxq5iXaG0MQx10t6UJk5/iOieCwr6x/tAjkI2Ky/eo=; b=h4IXQPJDj8YHONjk4ETa9siV09 nMPD0nLkHgjlPePuCfvCgPFGEu64OS5K9rNQE+RRzIScfObu25ScmVJUmVS+PAwqLrP/LCWFbAuSv mf6IuDZMLbp45vWTMVSD2eOvg; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:36134 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1huNwV-003cUt-At; Sun, 04 Aug 2019 16:21:27 -0500 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove some variables in favor of using gdb::optional References: <20190804201023.25628-1-simon.marchi@polymtl.ca> Date: Sun, 04 Aug 2019 21:21:00 -0000 In-Reply-To: <20190804201023.25628-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 4 Aug 2019 16:10:23 -0400") Message-ID: <874l2wiq3t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-08/txt/msg00097.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> While reading that code, I noticed that some variables essentially meant Simon> whether to consider some other variable or not. I think using Simon> gdb::optional (which was not available when this code was written) is Simon> clearer, as it embeds the used/not used predicate directly in the type Simon> of the variable, making it harder to miss. Thanks, this looks reasonable to me. Simon> + /* If set, only look for symbols that match that block. Valid values are Simon> + GLOBAL_BLOCK and STATIC_BLOCK. */ Simon> + gdb::optional block_index; I guess optional would be even better here. Tom